Fix qemu-io return value on failure
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest3 patches 1 replyIn review
- v42 patches 2 repliesSuperseded
- v3 posting 2/23 patches 0 repliesSuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 posting 1/2 | 3 patches | 6 replies | Superseded | |
| v2 | 2 patches | 0 replies | Superseded | |
| v1 | 1 patch | 4 replies | Superseded |
Changes in v5 from the cover letter
- Added _unsupported_fmt helper
- Test any format except raw, instead of only raw
- Don't test stderr content, depends on the format
- New test move to 174 since 173 is pending
- Private copyright for new test
- Fix commit message issues
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | qemu-io: Return non-zero exit code on failureqemu-io.c tests/ tests/ +10 more | +6 | 0 replies | |
| 2/3 | qemu-iotests: Add _unsupported_fmt helpertests/ | +11 | 0 replies | |
| 3/3 | qemu-io: Add failure regression teststests/ tests/ tests/ | +67 | 0 replies |
Reviews trailers per patch
1 of 3 patches has a Reviewed-by or Acked-by.
| Patch | Eric Blake |
|---|---|
| 1/3 | R-b |
| 2/3 | |
| 3/3 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH v5 0/3] Fix qemu-io return value on failure
This series fix qemu-io to fail with non zero exit code when failing to open the file.
Changes since v4:
- Added _unsupported_fmt helper
- Test any format except raw, instead of only raw
- Don't test stderr content, depends on the format
- New test move to 174 since 173 is pending
- Private copyright for new test
- Fix commit message issues
Changes since v3:
- Add cover letter
- Squash the tests fix with the behavior change, so git bisect landing on the change in behavior does not hit unnecessarily-broken tests.
Tested by running qemu-io manually and by running tests/check-block.sh. Note that test 059 has one unrelated test failure.
Nir Soffer (3):
qemu-io: Return non-zero exit code on failure
qemu-iotests: Add _unsupported_fmt helper
qemu-io: Add failure regression tests
qemu-io.c | 8 ++++-- tests/qemu-iotests/059.out | 3 --- tests/qemu-iotests/070.out | 1 - tests/qemu-iotests/075.out | 7 ------ tests/qemu-iotests/076.out | 3 --- tests/qemu-iotests/078.out | 6 ----- tests/qemu-iotests/080.out | 18 -------------- tests/qemu-iotests/083.out | 17 ------------- tests/qemu-iotests/088.out | 6 ----- tests/qemu-iotests/092.out | 12 --------- tests/qemu-iotests/116.out | 7 ------ tests/qemu-iotests/131.out | 1 - tests/qemu-iotests/140.out | 1 - tests/qemu-iotests/174 | 59 ++++++++++++++++++++++++++++++++++++++++++++ tests/qemu-iotests/174.out | 7 ++++++ tests/qemu-iotests/common.rc | 11 +++++++++ tests/qemu-iotests/group | 1 + 17 files changed, 84 insertions(+), 84 deletions(-) create mode 100755 tests/qemu-iotests/174 create mode 100644 tests/qemu-iotests/174.out
Signature · 1 line
2.9.3