Skip to content

Fix qemu-io return value on failure

Nir Soffer qemu-devel 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest3 patches 1 replyIn review
  2. v42 patches 2 repliesSuperseded
  3. v3 posting 2/23 patches 0 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v3 posting 1/23 patches6 repliesSuperseded
v22 patches0 repliesSuperseded
v11 patch4 repliesSuperseded

Changes in v5 from the cover letter

- Added _unsupported_fmt helper
- Test any format except raw, instead of only raw
- Don't test stderr content, depends on the format
- New test move to 174 since 173 is pending
- Private copyright for new test
- Fix commit message issues

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3qemu-io: Return non-zero exit code on failureqemu-io.c tests/qemu-iotests/059.out tests/qemu-iotests/070.out +10 more+6 -840 replies
2/3qemu-iotests: Add _unsupported_fmt helpertests/qemu-iotests/common.rc+11 -00 replies
3/3qemu-io: Add failure regression teststests/qemu-iotests/174 tests/qemu-iotests/174.out tests/qemu-iotests/group+67 -00 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchEric Blake
1/3R-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [Qemu-devel] [PATCH v5 0/3] Fix qemu-io return value on failure

This series fix qemu-io to fail with non zero exit code when failing to open the file.

Changes since v4:
- Added _unsupported_fmt helper
- Test any format except raw, instead of only raw
- Don't test stderr content, depends on the format
- New test move to 174 since 173 is pending
- Private copyright for new test
- Fix commit message issues

Changes since v3:
- Add cover letter
- Squash the tests fix with the behavior change, so git bisect landing on the change in behavior does not hit unnecessarily-broken tests.

Tested by running qemu-io manually and by running tests/check-block.sh. Note that test 059 has one unrelated test failure.

Nir Soffer (3):
qemu-io: Return non-zero exit code on failure
qemu-iotests: Add _unsupported_fmt helper
qemu-io: Add failure regression tests

 qemu-io.c                    |  8 ++++--
 tests/qemu-iotests/059.out   |  3 ---
 tests/qemu-iotests/070.out   |  1 -
 tests/qemu-iotests/075.out   |  7 ------
 tests/qemu-iotests/076.out   |  3 ---
 tests/qemu-iotests/078.out   |  6 -----
 tests/qemu-iotests/080.out   | 18 --------------
 tests/qemu-iotests/083.out   | 17 -------------
 tests/qemu-iotests/088.out   |  6 -----
 tests/qemu-iotests/092.out   | 12 ---------
 tests/qemu-iotests/116.out   |  7 ------
 tests/qemu-iotests/131.out   |  1 -
 tests/qemu-iotests/140.out   |  1 -
 tests/qemu-iotests/174       | 59 ++++++++++++++++++++++++++++++++++++++++++++
 tests/qemu-iotests/174.out   |  7 ++++++
 tests/qemu-iotests/common.rc | 11 +++++++++
 tests/qemu-iotests/group     |  1 +
 17 files changed, 84 insertions(+), 84 deletions(-)
 create mode 100755 tests/qemu-iotests/174
 create mode 100644 tests/qemu-iotests/174.out
Signature · 1 line
2.9.3