fujitsu_init() cleanup
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest4 patches 2 repliesIn review
- v34 patches 5 repliesSuperseded
- v24 patches 12 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 4 patches | 19 replies | Superseded |
Changes in v4 from the cover letter
- Do not use KBUILD_MODNAME as backlight device name as it breaks userspace interface ("fujitsu-laptop" vs. "fujitsu_laptop").
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | platform/x86: fujitsu-laptop: register backlight device in a separate functiondrivers/ | +22 | 0 replies | |
| 2/4 | platform/x86: fujitsu-laptop: sync backlight power status in acpi_fujitsu_laptop_add()drivers/ | +8 | 0 replies | |
| 3/4 | platform/x86: fujitsu-laptop: only register backlight device if FUJ02B1 is presentdrivers/ | +10 | 0 replies | |
| 4/4 | platform/x86: fujitsu-laptop: cleanup error labels in fujitsu_init()drivers/ | +14 | 0 replies |
Reviews trailers per patch
None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Jonathan Woithe |
|---|---|
| Series | T-b R-b |
| 1/4 | |
| 2/4 | |
| 3/4 | |
| 4/4 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 0/4] fujitsu_init() cleanup
These patches should make fujitsu_init() a bit more palatable. No changes are made to platform device code yet, for clarity these will be posted in a separate series after this one gets applied.
Changes from v3:
- Do not use KBUILD_MODNAME as backlight device name as it breaks userspace interface ("fujitsu-laptop" vs. "fujitsu_laptop").
Changes from v2:
- Patch 2/4 from v2 did not work as expected and was thus replaced with a rebased version of patch 3/4 from v1.
- Added a check in patch 3/4 to prevent a NULL dereference when ACPI device FUJ02B1 is not present and ACPI device FUJ02E3 is.
Changes from v1:
- Rebase on top of reworked Alan Jenkins' cleanup patch series.
- Drop patch 1/4 from v1 as it has already been applied in reworked Alan Jenkins' cleanup patch series.
- Patch 3/4 from v1 has been replaced with a completely different one (patch 2/4). It needs to be tested on a relevant machine as it is based purely on a dump of a DSDT table (further details can be found in the patch itself).
- Patch 3/4 in v2 is a rebased version of patch 8/10 from the reworked Alan Jenkins' cleanup patch series. Patch 2/4 from v2 (the one mentioned in the previous bullet point) ensures this one can be safely applied without causing a NULL dereference under any circumstances.
drivers/platform/x86/fujitsu-laptop.c | 98 ++++++++++++++++++----------------- 1 file changed, 50 insertions(+), 48 deletions(-)
Signature · 1 line
2.12.0