Skip to content

Expanding raw packet capabilities

Leon Romanovsky linux-rdma 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11IB/core: Expose vlan offloads capabilitiesinclude/rdma/ib_verbs.h+15 -00 replies
2/11IB/core: Enable WQ creation and modification with cvlan offloadinclude/rdma/ib_verbs.h+10 -20 replies
3/11IB/core: Enable QP creation with cvlan offloadinclude/rdma/ib_verbs.h+1 -00 replies
4/11IB/core: Add scatter FCS flag to use in WQ creationinclude/rdma/ib_verbs.h+1 -00 replies
5/11IB/uverbs: Expose vlan offloads capabilitiesdrivers/infiniband/core/uverbs_cmd.c include/uapi/rdma/ib_user_verbs.h+7 -10 replies
6/11IB/uverbs: Enable WQ creation and modification with cvlan offloaddrivers/infiniband/core/uverbs_cmd.c include/uapi/rdma/ib_user_verbs.h+12 -10 replies
7/11IB/uverbs: Enable QP creation with cvlan offloaddrivers/infiniband/core/uverbs_cmd.c+2 -10 replies
8/11IB/mlx5: Expose vlan offloads capabilitiesdrivers/infiniband/hw/mlx5/main.c+12 -20 replies
9/11IB/mlx5: Enable WQ creation and modification with cvlan offloaddrivers/infiniband/hw/mlx5/qp.c+27 -10 replies
10/11IB/mlx5: Enable QP creation with cvlan offloaddrivers/infiniband/hw/mlx5/mlx5_ib.h drivers/infiniband/hw/mlx5/qp.c+18 -10 replies
11/11IB/mlx5: Support creation of a WQ with scatter FCS offloaddrivers/infiniband/hw/mlx5/qp.c+11 -20 replies

Reviews trailers per patch

All 11 patches have a Reviewed-by or Acked-by.

PatchMaor GottliebYishai HadasMajd Dibbiny
1/11R-b R-b
2/11R-b R-b
3/11R-b R-b
4/11R-b R-b
5/11R-b R-b
6/11R-b R-b
7/11R-b R-b
8/11R-b R-b
9/11R-b R-b
10/11R-b R-b
11/11R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH rdma-next 00/11] Expanding raw packet capabilities

Hi Doug,

Please find the following patchset from Noa.

This series unifies all existing raw packet capabilities under a new field in ib_device_attr named raw_packet_caps. This field is defined by the ib_raw_packet_caps enum. Such change makes it easier to report those capabilities back to the user.

The existing IP csum and scatter FCS capabilities were added to the enum and a new capability was introduced - cvlan stripping offload.

Cvlan stripping is the device's capability to remove the cvlan from an incoming raw packet and provide the data in the matching work completion.

This series also:
- Allows creation of WQ and raw Ethernet QP with cvlan stripping capability. This is done by setting the IBV_WQ_FLAGS_CVLAN_STRIPPING bit of the create_flags field in ibv_wq_init_attr struct.
- Allows setting and unsetting of cvlan stripping capability for an existing WQ. This is done by setting the following fields of the ibv_wq_attr struct:
- Setting IBV_WQ_ATTR_FLAGS bit of the attr_mask field.
- Setting the IBV_RAW_PACKET_CAP_CVLAN_STRIPPING bit of the flags_mask field.
- Either setting or unsetting the IBV_RAW_PACKET_CAP_CVLAN_STRIPPING bit of the flags field.
- Allows creation of WQ with scatter FCS offload.
This is done by setting the IBV_WQ_FLAGS_SCATTER_FCS bit of the create_flags field in ibv_wq_init_attr struct.

Thanks,
Noa
---

This patchset was generated against commit
f502d834950a ("net/mlx5: Activate support for 4K UARs") and it applies cleanly on k.o/for-4.11 branch.

Available in the "topic/raw_packet_caps" topic branch of this git repo:
git://git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git

Or for browsing:
https://git.kernel.org/cgit/linux/kernel/git/leon/linux-rdma.git/log/?h=topic/raw_packet_caps

Noa Osherovich (11):
IB/core: Expose vlan offloads capabilities
IB/core: Enable WQ creation and modification with cvlan offload IB/core: Enable QP creation with cvlan offload IB/core: Add scatter FCS flag to use in WQ creation IB/uverbs: Expose vlan offloads capabilities IB/uverbs: Enable WQ creation and modification with cvlan offload IB/uverbs: Enable QP creation with cvlan offload IB/mlx5: Expose vlan offloads capabilities
IB/mlx5: Enable WQ creation and modification with cvlan offload IB/mlx5: Enable QP creation with cvlan offload IB/mlx5: Support creation of a WQ with scatter FCS offload

 drivers/infiniband/core/uverbs_cmd.c | 18 +++++++++++--
 drivers/infiniband/hw/mlx5/main.c    | 14 ++++++++--
 drivers/infiniband/hw/mlx5/mlx5_ib.h |  6 +++++
 drivers/infiniband/hw/mlx5/qp.c      | 50 ++++++++++++++++++++++++++++++++++--
 include/rdma/ib_verbs.h              | 29 +++++++++++++++++++--
 include/uapi/rdma/ib_user_verbs.h    |  6 ++++-
 6 files changed, 114 insertions(+), 9 deletions(-)

--
2.10.2

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html