Skip to content

ceph: implement new-style ENOSPC handling in kcephfs

Jeff Layton ceph-devel 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest6 patches 16 repliesIn review
  2. v46 patches 9 repliesSuperseded
  3. v35 patches 2 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v26 patches8 repliesSuperseded
v17 patches8 repliesSuperseded

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6libceph: allow requests to return immediately on full conditions if caller wishesfs/ceph/addr.c fs/ceph/file.c include/linux/ceph/osd_client.h +1 more+10 -03 replies
2/6libceph: abort already submitted but abortable requests when map or pool goes fullnet/ceph/osd_client.c+42 -07 replies
3/6libceph: add an epoch_barrier field to struct ceph_osd_clientinclude/linux/ceph/osd_client.h net/ceph/osd_client.c+43 -105 replies
4/6ceph: handle epoch barriers in cap messagesfs/ceph/caps.c fs/ceph/mds_client.c fs/ceph/mds_client.h+38 -60 replies
5/6Revert "ceph: SetPageError() for writeback pages if writepages fails"fs/ceph/addr.c+0 -30 replies
6/6ceph: when seeing write errors on an inode, switch to sync writesfs/ceph/addr.c fs/ceph/file.c fs/ceph/super.h+49 -140 replies

Reviews trailers per patch

None of the 6 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchYan, Zheng”
SeriesR-b
1/6
2/6
3/6
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/6] ceph: implement new-style ENOSPC handling in kcephfs

v5: rebase onto ACK vs. commit changes

v4: eliminate map_cb and just call ceph_osdc_abort_on_full directly Revert earlier patch flagging individual pages with error on writeback failure. Add mechanism to force synchronous writes when writes start failing, and reallowing async writes when they succeed.

v3: track "abort_on_full" behavior with a new bool in osd request instead of a protocol flag. Remove some extraneous arguments from various functions. Don't export have_pool_full, call it from the abort_on_full callback instead.

v2: teach libcephfs how to hold on to requests until the right map epoch appears, instead of delaying cap handling in the cephfs layer.

Ok, with this set, I think we have proper -ENOSPC handling for all different write types (direct, sync, async buffered, etc...). -ENOSPC conditions.

This patchset is an updated version of the patch series originally done by John Spray and posted here:

    http://www.spinics.net/lists/ceph-devel/msg21257.html

The only real change from the last posting was to rebase it on top of Ilya's changes to remove the ack vs. commit behavior. That rebase was fairly simple and turns out to simplify the changes somewhat.

In the last series Zheng also mentioned removing the other SetPageError sites in fs/ceph. That may make sense, but I've left that out for now, as I'd like to look over PG_error handling in the kernel at large.

Jeff Layton (6):
libceph: allow requests to return immediately on full conditions if
caller wishes
libceph: abort already submitted but abortable requests when map or
pool goes full
libceph: add an epoch_barrier field to struct ceph_osd_client
ceph: handle epoch barriers in cap messages
Revert "ceph: SetPageError() for writeback pages if writepages fails"
ceph: when seeing write errors on an inode, switch to sync writes

 fs/ceph/addr.c                  | 10 +++--
 fs/ceph/caps.c                  | 17 ++++++--
 fs/ceph/file.c                  | 32 ++++++++------
 fs/ceph/mds_client.c            | 20 +++++++++
 fs/ceph/mds_client.h            |  7 ++-
 fs/ceph/super.h                 | 26 +++++++++++
 include/linux/ceph/osd_client.h |  3 ++
 net/ceph/osd_client.c           | 96 +++++++++++++++++++++++++++++++++++++----
 8 files changed, 180 insertions(+), 31 deletions(-)
Signature · 1 line
2.9.3