Skip to content

Export APIs to copy device properties & more

Dmitry Torokhov linux-acpi lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest4 patches 10 repliesIn review
  2. v34 patches 5 repliesSuperseded
  3. v24 patches 4 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches6 repliesSuperseded

Changes in v5 from the cover letter

- reshuffle order of patches so that "constness" ones are first
- factor out property_entry_free_data() and make sure we call it for properties already successfully copied when property_entry_copy_data() in property_entries_dup() fails
- dropped old Acks as patches changed enough

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4device property: allow to constify propertiesdrivers/base/property.c include/linux/property.h+22 -212 replies
2/4device property: constify property arrays valuesdrivers/base/property.c include/linux/property.h+11 -112 replies
3/4device property: export code duplicating array of property entriesdrivers/base/property.c include/linux/property.h+134 -652 replies
4/4i2c: allow specify device properties in i2c_board_infodrivers/i2c/i2c-core.c include/linux/i2c.h+18 -13 replies

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by.

PatchAndy ShevchenkoWolfram Sang
1/4R-b
2/4
3/4
4/4R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/4] Export APIs to copy device properties & more

Hi,

Here is the refreshed series exporting APIs to copy statically declared device properties. The reason is that we want to augment ACPI-based devices with properties, and drivers usually have a largish DMI table for multiple models, so it is desirable to mark everything as __initdata/__initconst, and then copy only the entry matching the device we are running on and discard the rest.

The last patch is not really about device property APIs, but rather allowing users to attach properties to i2c_board_info, and have them attached to instantiated device(s). The reason it is included is because it depends on device_add_properties() taking const pointer, which is patch #1.

If it seems useful I hope Rafael and Wolfram would figure a way to merge it :) and ideally give me a stable branch as I have more patches to platform/chrome and Atmel touchscreen driver depending on them.

v5:
- reshuffle order of patches so that "constness" ones are first
- factor out property_entry_free_data() and make sure we call it for properties already successfully copied when property_entry_copy_data() in property_entries_dup() fails
- dropped old Acks as patches changed enough

v4:
- do not clobber retrun value of property_copy_string_array() with -ENOMEM

v3:
- fix memory leak in property_copy_string_array() pointed out by Mika Westerberg

v2:
- addressed Andy's comments
- added property_entries_free()
- added patch to allow constify values of property arrays
- added i2c patch allowing to attach property to devices via board info

v1:
- initial posting

Dmitry Torokhov (4):
device property: allow to constify properties
device property: constify property arrays values
device property: export code duplicating array of property entries
i2c: allow specify device properties in i2c_board_info

 drivers/base/property.c  | 229 ++++++++++++++++++++++++++++++-----------------
 drivers/i2c/i2c-core.c   |  16 +++-
 include/linux/i2c.h      |   3 +
 include/linux/property.h |  19 ++--
 4 files changed, 177 insertions(+), 90 deletions(-)
Signature · 1 line
Dmitry