Skip to content

sysctl: few fixes

Luis R. Rodriguez lkml 3 versions – Applied

Status from this message: [merged] sysctl-add-unsigned-int-range-support.patch removed from -mm tree

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 1 replyApplied 5/5
  2. v29 patches 12 repliesSuperseded
  3. v11 patch 4 repliesSuperseded

Patches in v3 All 5 applied

#Subject and filesSizeRepliesApplied
1/5sysctl: fix lax sysctl_check_table() sanity checkfs/proc/proc_sysctl.c+5 -51 replyApplied
2/5sysctl: kdoc'ify sysctl_writes_strictkernel/sysctl.c+25 -40 repliesApplied
3/5sysctl: fold sysctl_writes_strict checks into helperkernel/sysctl.c+32 -240 repliesApplied
4/5sysctl: simplify unsigned int supportfs/proc/proc_sysctl.c kernel/sysctl.c+160 -70 repliesApplied
5/5sysctl: add unsigned int range supportfs/proc/proc_sysctl.c include/linux/sysctl.h kernel/sysctl.c+72 -10 repliesApplied

Reviews trailers per patch

1 of 5 patches has a Reviewed-by or Acked-by.

PatchKees Cook
1/5
2/5
3/5
4/5
5/5A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/5] sysctl: few fixes

I've been working on making kmod more deterministic, and as I did that I couldn't help but notice a few issues with sysctl. My end goal was just to fix unsigned int support, which back then was completely broken. Liping Zhang has sent up small atomic fixes, however it still missed yet one more fix and Alexey Dobriyan had also suggested to just drop array support given its complexity.

I have inspected array support using Coccinelle and indeed its not that popular, so if in fact we can avoid it for new interfaces, I agree its best.

I did develop a sysctl stress driver but will hold that off for another series.

Luis R. Rodriguez (5):
sysctl: fix lax sysctl_check_table() sanity check
sysctl: kdoc'ify sysctl_writes_strict
sysctl: fold sysctl_writes_strict checks into helper
sysctl: simplify unsigned int support
sysctl: add unsigned int range support

 fs/proc/proc_sysctl.c  |  26 ++++-
 include/linux/sysctl.h |   3 +
 kernel/sysctl.c        | 304 +++++++++++++++++++++++++++++++++++++++++++------
 3 files changed, 293 insertions(+), 40 deletions(-)
Signature · 1 line
2.11.0