Skip to content

gtp: misc improvements

Andreas Schultz netdev 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest7 patches 5 repliesIn review
  2. v47 patches 8 repliesSuperseded
  3. v38 patches 9 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v26 patches22 repliesSuperseded

Changes in v5 from the cover letter

* resent for new merge window

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7gtp: switch from struct socket to struct sock for the GTP socketsdrivers/net/gtp.c+23 -190 replies
2/7gtp: make GTP sockets in gtp_newlink optionaldrivers/net/gtp.c+78 -700 replies
3/7gtp: merge gtp_get_net and gtp_genl_find_devdrivers/net/gtp.c+69 -770 replies
4/7gtp: consolidate gtp socket rx pathdrivers/net/gtp.c+44 -360 replies
5/7gtp: unify genl_find_pdp and prepare for per socket lookupdrivers/net/gtp.c+50 -710 replies
6/7gtp: consolidate pdp context destruction into helperdrivers/net/gtp.c+14 -100 replies
7/7gtp: add socket to pdp contextdrivers/net/gtp.c+47 -470 replies

Reviews trailers per patch

None of the 7 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchPablo Neira Ayuso
SeriesA-b
1/7
2/7
3/7
4/7
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH net-next v5 0/7] gtp: misc improvements

Hi Pablo,

This is a resent of last series that missed the merge window. There are no changes compared to v4.

v4: Compared to v3 it contains mostly smallish naming and spelling fixes. It also drops the documentation patch, Harald did a better job with the documentation and the some things I described do not yet match the implementation. I'll readd the relevant parts with a follow up series.

This series lays the groundwork for removing the socket references from the GTP netdevice by removing duplicate code and simplifying the logic on some code paths.

It slighly changes the GTP genl API by making the socket parameters optional (though one of them is still required).

The removal of the socket references will break the 1:1 releation between GTP netdevice and GTP socket that prevents us to support multiple VRFs with overlapping IP addresse spaces attached to the same GTP-U entity (needed for multi APN support, coming a follow up series).

Pablo found a socket hold problem in v2. In order to solve that I had to switch the socket references from the struct socket to the internal struct sock. This should have no functionl impact, but we can now hang on to the reference without blocking user space from closing the GTP socket.

v4->v5:
* resent for new merge window
v3->v4:
* drop the documentation patch
* spelling fixes
* pass nlattr instead of genl_info into gtp_find_dev, makes the code slightly more compact and readable
v2->v3:
* add documentation to explain the goal of all these changes
* incorporate review comments
* switch from struct socket to struct sock

Regards
Andreas