Skip to content

Fix 3 coding style errors and 447 warnings in f2fs.h

DongOh Shin linux-f2fs-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2Fix 3 coding style errors in f2fs.hfs/f2fs/f2fs.h+3 -30 replies
2/2Fix 446 coding style warnings in f2fs.hfs/f2fs/f2fs.h+270 -2280 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] Fix 3 coding style errors and 447 warnings in f2fs.h

f2fs.h has 3 errors and 454 warnings on the coding style.
The patches resolve 3 errors and 446 warnings below:
0001, error, "Macros with complex values should be enclosed in parentheses"
0001, error, "space prohibited before that ',' (ctx:WxW)"
0002, warning, "Missing a blank line after declarations"
0002, warning, "function definition argument 'x' should also have an identifier name" 0002, warning, "macros should not use a trailing semicolon"

So there are only 8 warnings in f2fs.h after applying these. The patches are tested under 'next-20170125'. Thanks,

DongOh Shin (2):
Fix 3 coding style errors in f2fs.h
Fix 446 coding style warnings in f2fs.h

 fs/f2fs/f2fs.h | 502 +++++++++++++++++++++++++++++++--------------------------
 1 file changed, 272 insertions(+), 230 deletions(-)
Signature · 6 lines
1.8.3.1


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot