Skip to content

sd: sdhci: correct transfer mode register usage

P J P qemu-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest4 patches 8 repliesIn review
  2. v34 patches 4 repliesSuperseded
  3. v23 patches 2 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches8 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4sd: sdhci: mask transfer mode register valuehw/sd/sdhci.c+2 -11 reply
2/4sd: sdhci: check transfer mode register in multi block transferhw/sd/sdhci.c+5 -54 replies
3/4sd: sdhci: conditionally invoke multi block transferhw/sd/sdhci.c+5 -10 replies
4/4sd: sdhci: Remove block count enable check in single block transfershw/sd/sdhci.c+1 -51 reply

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by.

PatchAlistair Francis
1/4R-b
2/4
3/4
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [Qemu-devel] [PATCH v4 0/4] sd: sdhci: correct transfer mode register usage

From: Prasad J Pandit <[email protected]>

Hello,

In SDHCI protocol, the 'Block Count Enable' bit of the Transfer Mode register is used to control 's->blkcnt' value. This bit is not relevant in single block transfers. Also, Transfer Mode register value could be set such that 's->blkcnt' would not see an update during multi block transfers. Thus leading to an infinite loop.

This patch set attempts to correct 'Block Count Enable' bit usage.

This series incorporates changes suggested in patch set v3:
-> https://lists.gnu.org/archive/html/qemu-devel/2017-02/msg02376.html
-> https://lists.gnu.org/archive/html/qemu-devel/2017-02/msg02905.html

Thank you.
--
Prasad J Pandit (4):
sd: sdhci: mask transfer mode register value
sd: sdhci: check transfer mode register in multi block transfer
sd: sdhci: conditionally invoke multi block transfer
sd: sdhci: Remove block count enable check in single block transfers

 hw/sd/sdhci.c | 25 +++++++++++++------------
 1 file changed, 13 insertions(+), 12 deletions(-)
Signature · 1 line
2.9.3