Intel LPE audio driver cleanups
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest53 patches 4 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/53 | ALSA: x86: Don't set PCM state to DISCONNECTEDsound/ | +1 | 0 replies | |
| 2/53 | ALSA: x86: Remove v1 ops and structssound/ sound/ | +1 | 0 replies | |
| 3/53 | ALSA: x86: Drop indirect calls of had_opssound/ sound/ sound/ | +42 | 0 replies | |
| 4/53 | ALSA: x86: Replace indirect register ops with direct callssound/ sound/ sound/ +2 more | +30 | 0 replies | |
| 5/53 | ALSA: x86: Replace indirect query_ops with direct callssound/ sound/ sound/ +1 more | +16 | 0 replies | |
| 6/53 | ALSA: x86: Drop snd_intel_had_interface indirect callssound/ sound/ sound/ +2 more | +23 | 0 replies | |
| 7/53 | ALSA: x86: Pass snd_intelhad object to helperssound/ sound/ sound/ +2 more | +131 | 0 replies | |
| 8/53 | ALSA: x86: Handle the error from hdmi_audio_probe() properlysound/ | +16 | 0 replies | |
| 9/53 | ALSA: x86: Drop useless mutex at probesound/ | +2 | 0 replies | |
| 10/53 | ALSA: x86: Call event callback directlysound/ sound/ sound/ +1 more | +1 | 0 replies | |
| 11/53 | ALSA: x86: Fix possible stale interrupt callssound/ | +13 | 0 replies | |
| 12/53 | ALSA: x86: Drop unused mid_hdmi_audio_is_busy()sound/ sound/ | +0 | 0 replies | |
| 13/53 | ALSA: x86: Drop the global platform device referencesound/ sound/ sound/ | +87 | 0 replies | |
| 14/53 | ALSA: x86: Drop global hlpe_statesound/ | +9 | 0 replies | |
| 15/53 | ALSA: x86: Drop global ELD copysound/ | +5 | 0 replies | |
| 16/53 | ALSA: x86: Move the global underrun_count to struct snd_intelhadsound/ sound/ | +9 | 0 replies | |
| 17/53 | ALSA: x86: Drop unused hw_silence fieldsound/ sound/ | +0 | 4 replies | |
| 18/53 | ALSA: x86: Move dma_mask debug print into intel_hdmi_lpe_audio.csound/ sound/ | +1 | 0 replies | |
| 19/53 | ALSA: x86: Embed snd_intelhad into snd_cardsound/ sound/ sound/ | +31 | 0 replies | |
| 20/53 | ALSA: x86: Drop superfluous CHT PCI ID checksound/ | +0 | 0 replies | |
| 21/53 | ALSA: x86: Check platform_data earliersound/ | +6 | 0 replies | |
| 22/53 | ALSA: x86: Call snd_card_register() at the endsound/ | +5 | 0 replies | |
| 23/53 | ALSA: x86: Drop unused hdmi_audio_query()sound/ sound/ | +0 | 0 replies | |
| 24/53 | ALSA: x86: Flatten two abstraction layerssound/ sound/ sound/ +3 more | +358 | 0 replies | |
| 25/53 | ALSA: x86: Fold intel_hdmi_audio_if.c into main filesound/ sound/ sound/ +1 more | +376 | 0 replies | |
| 26/53 | ALSA: x86: Replace pr_xxx() with dev_xxx()sound/ | +84 | 0 replies | |
| 27/53 | ALSA: x86: Fix for CONFIG_PM=nsound/ | +1 | 0 replies | |
| 28/53 | ALSA: x86: Remove indirect call of snd_pcm_period_elapsed()sound/ sound/ | +7 | 0 replies | |
| 29/53 | ALSA: x86: Drop unused fields from snd_intelhad structsound/ sound/ | +6 | 0 replies | |
| 30/53 | ALSA: x86: Drop superfluous PCM private_freesound/ | +0 | 0 replies | |
| 31/53 | ALSA: x86: Fix sleep-in-atomic via i915 notificationsound/ | +24 | 0 replies | |
| 32/53 | ALSA: x86: Remove superfluous check at resumesound/ | +1 | 0 replies | |
| 33/53 | ALSA: x86: Drop had_get_hwstate()sound/ | +14 | 0 replies | |
| 34/53 | ALSA: x86: Tidy up codessound/ | +59 | 0 replies | |
| 35/53 | ALSA: x86: Remove _v[12] sufficessound/ sound/ sound/ | +31 | 0 replies | |
| 36/53 | ALSA: x86: Constfy tablessound/ | +3 | 0 replies | |
| 37/53 | ALSA: x86: Remove superfluous irqsave flagssound/ | +33 | 0 replies | |
| 38/53 | ALSA: x86: Fix racy access to chmapsound/ sound/ | +24 | 0 replies | |
| 39/53 | ALSA: x86: Drop flag_underrun fieldsound/ sound/ | +1 | 0 replies | |
| 40/53 | ALSA: x86: Drop superfluous state fieldsound/ sound/ sound/ | +21 | 0 replies | |
| 41/53 | ALSA: x86: Drop redundant had_stream_pvtsound/ sound/ sound/ | +4 | 0 replies | |
| 42/53 | ALSA: x86: Drop unused fields from pcm_stream_infosound/ sound/ | +1 | 0 replies | |
| 43/53 | ALSA: x86: Properly manage PCM substream lifetypesound/ sound/ | +98 | 0 replies | |
| 44/53 | ALSA: x86: Implement runtime PMsound/ | +50 | 0 replies | |
| 45/53 | ALSA: x86: Move stream status into pcm_stream_infosound/ sound/ sound/ | +14 | 0 replies | |
| 46/53 | ALSA: x86: Use the standard ELD bytes definitionssound/ sound/ sound/ | +9 | 0 replies | |
| 47/53 | ALSA: x86: Reduce redundant register field namessound/ sound/ sound/ | +90 | 0 replies | |
| 48/53 | ALSA: x86: Clean up unused defines and inclusionssound/ sound/ sound/ | +20 | 0 replies | |
| 49/53 | ALSA: x86: Create ELD control elementsound/ | +51 | 0 replies | |
| 50/53 | ALSA: x86: Set CA bits for DisplayPort toosound/ | +4 | 0 replies | |
| 51/53 | ALSA: x86: Simplify commentssound/ | +14 | 0 replies | |
| 52/53 | ALSA: x86: Yet more tidy-up and clean-upssound/ | +36 | 0 replies | |
| 53/53 | ALSA: x86: Rename drv_status to connectedsound/ sound/ sound/ | +22 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 00/53] Intel LPE audio driver cleanups
Hi,
this is a fairly largish patchset to fix and clean up Intel LPE audio driver. Most of the patches are to clean up and refactoring of the codes. As you can see in the diffstat below, quite lots of codes (over 1600 lines) are reduced. Now the driver structure is flattened to a single layer, and it looks much like a normal driver.
Besides the refactoring, there are a few major fixes: e.g. the fix for the PCM disconnection that confuses PA,. the fix for the possible sleep-in-atomic at hotplug, the fix for racy chmap accesses.
As new features, the driver supports the runtime PM properly now, it sets the CA bit for DP, and it exposes the ELD via ALSA control element.
The current code is available in topic/intel-lpe-audio-cleanup branch, and it's based on the DP-audio branch, topic/intel-lpe-audio-dp that I'm going to merge to for-next soon.
Takashi
===
Takashi Iwai (53):
ALSA: x86: Don't set PCM state to DISCONNECTED
ALSA: x86: Remove v1 ops and structs
ALSA: x86: Drop indirect calls of had_ops
ALSA: x86: Replace indirect register ops with direct calls
ALSA: x86: Replace indirect query_ops with direct calls
ALSA: x86: Drop snd_intel_had_interface indirect calls
ALSA: x86: Pass snd_intelhad object to helpers
ALSA: x86: Handle the error from hdmi_audio_probe() properly
ALSA: x86: Drop useless mutex at probe
ALSA: x86: Call event callback directly
ALSA: x86: Fix possible stale interrupt calls
ALSA: x86: Drop unused mid_hdmi_audio_is_busy()
ALSA: x86: Drop the global platform device reference
ALSA: x86: Drop global hlpe_state
ALSA: x86: Drop global ELD copy
ALSA: x86: Move the global underrun_count to struct snd_intelhad
ALSA: x86: Drop unused hw_silence field
ALSA: x86: Move dma_mask debug print into intel_hdmi_lpe_audio.c
ALSA: x86: Embed snd_intelhad into snd_card
ALSA: x86: Drop superfluous CHT PCI ID check
ALSA: x86: Check platform_data earlier
ALSA: x86: Call snd_card_register() at the end
ALSA: x86: Drop unused hdmi_audio_query()
ALSA: x86: Flatten two abstraction layers
ALSA: x86: Fold intel_hdmi_audio_if.c into main file
ALSA: x86: Replace pr_xxx() with dev_xxx()
ALSA: x86: Fix for CONFIG_PM=n
ALSA: x86: Remove indirect call of snd_pcm_period_elapsed()
ALSA: x86: Drop unused fields from snd_intelhad struct
ALSA: x86: Drop superfluous PCM private_free
ALSA: x86: Fix sleep-in-atomic via i915 notification
ALSA: x86: Remove superfluous check at resume
ALSA: x86: Drop had_get_hwstate()
ALSA: x86: Tidy up codes
ALSA: x86: Remove _v[12] suffices
ALSA: x86: Constfy tables
ALSA: x86: Remove superfluous irqsave flags
ALSA: x86: Fix racy access to chmap
ALSA: x86: Drop flag_underrun field
ALSA: x86: Drop superfluous state field
ALSA: x86: Drop redundant had_stream_pvt
ALSA: x86: Drop unused fields from pcm_stream_info
ALSA: x86: Properly manage PCM substream lifetype
ALSA: x86: Implement runtime PM
ALSA: x86: Move stream status into pcm_stream_info
ALSA: x86: Use the standard ELD bytes definitions
ALSA: x86: Reduce redundant register field names
ALSA: x86: Clean up unused defines and inclusions
ALSA: x86: Create ELD control element
ALSA: x86: Set CA bits for DisplayPort too
ALSA: x86: Simplify comments
ALSA: x86: Yet more tidy-up and clean-ups
ALSA: x86: Rename drv_status to connected
sound/x86/Makefile | 4 +- sound/x86/intel_hdmi_audio.c | 1901 +++++++++++++++++++------------------- sound/x86/intel_hdmi_audio.h | 117 +-- sound/x86/intel_hdmi_audio_if.c | 548 ----------- sound/x86/intel_hdmi_lpe_audio.c | 665 ------------- sound/x86/intel_hdmi_lpe_audio.h | 470 ++-------- 6 files changed, 1026 insertions(+), 2679 deletions(-) delete mode 100644 sound/x86/intel_hdmi_audio_if.c delete mode 100644 sound/x86/intel_hdmi_lpe_audio.c
Signature · 1 line
2.11.0