Skip to content

nbd: BLOCK_STATUS

Vladimir Sementsov-Ogievskiy qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest18 patches 39 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18nbd: rename NBD_REPLY_MAGIC to NBD_SIMPLE_REPLY_MAGICnbd/client.c nbd/nbd-internal.h nbd/server.c +1 more+7 -71 reply
2/18nbd-server: refactor simple reply sendinginclude/block/nbd.h nbd/server.c+20 -121 reply
3/18nbd: Minimal structured read for serverinclude/block/nbd.h nbd/nbd-internal.h nbd/server.c+154 -45 replies
4/18nbd/client: refactor nbd_receive_starttlsnbd/client.c nbd/nbd-internal.h+49 -196 replies
5/18nbd/client: fix drop_syncnbd/client.c+1 -12 replies
6/18nbd/client: refactor drop_syncnbd/client.c+19 -163 replies
7/18nbd: Minimal structured read for clientblock/nbd-client.c block/nbd-client.h include/block/nbd.h +2 more+203 -334 replies
8/18hbitmap: add next_zero functionblock/dirty-bitmap.c include/block/dirty-bitmap.h include/qemu/hbitmap.h +1 more+41 -02 replies
9/18block/dirty-bitmap: add bdrv_dirty_bitmap_next()block/dirty-bitmap.c include/block/dirty-bitmap.h+10 -00 replies
10/18block/dirty-bitmap: add bdrv_load_dirty_bitmapblock/dirty-bitmap.c include/block/block_int.h include/block/dirty-bitmap.h+60 -02 replies
11/18nbd: BLOCK_STATUS for bitmap export: server partinclude/block/nbd.h nbd/nbd-internal.h nbd/server.c+466 -02 replies
12/18nbd: BLOCK_STATUS for bitmap export: client partblock/nbd-client.c block/nbd-client.h block/nbd.c +5 more+270 -91 reply
13/18nbd: add nbd_dirty_bitmap_loadblock/nbd.c+32 -00 replies
14/18qmp: add x-debug-block-dirty-bitmap-sha256block/dirty-bitmap.c blockdev.c include/block/dirty-bitmap.h +4 more+83 -10 replies
15/18qmp: add block-dirty-bitmap-loadblockdev.c qapi/block-core.json+42 -03 replies
16/18iotests: add test for nbd dirty bitmap exporttests/qemu-iotests/180 tests/qemu-iotests/180.out tests/qemu-iotests/group+139 -00 replies
17/18nbd: BLOCK_STATUS for standard get_block_status function: server partinclude/block/nbd.h nbd/nbd-internal.h nbd/server.c+77 -73 replies
18/18nbd: BLOCK_STATUS for standard get_block_status function: client partblock/nbd-client.c block/nbd-client.h block/nbd.c +3 more+66 -102 replies

Reviews trailers per patch

4 of 18 patches have a Reviewed-by or Acked-by.

PatchMax ReitzEric Blake
1/18R-b
2/18R-b
3/18
4/18
5/18R-b
6/18
7/18
8/18
9/18R-b
10/18
11/18
12/18
13/18
14/18
15/18
16/18
17/18
18/18

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 00/18] nbd: BLOCK_STATUS

Hi all!

We really need exporting dirty bitmaps feature as well as remote get_block_status for nbd devices. So, here is minimalistic and restricted realization of 'structured reply' and 'block status' nbd protocol extension (as second is developed over the first the combined spec may be found here:
https://github.com/NetworkBlockDevice/nbd/blob/extension-blockstatus/doc/proto.md)

What is done:

server:
- can send not fragmented structured replies for CMD_READ (this was done only because the spec doesn't allow structure reply feature without maintaining structured read)
- can export dirty bitmap through BLOCK_STATUS. Only one bitmap can be exported, negotiation query should be 'qemu-dirty-bitmap:<bitmap name>'
- cab export block status through BLOCK_STATUS. Client can negotiate only one entity for exporting through BLOCK_STATUS - bitmap _or_ block status. negotiation query should be 'base:allocation', as defined in the spec. server sends only one extent on each BLOCK_STATUS query.

client:
- can receive not fragmented structured replies for CMD_READ
- can get load dirty bitmap through nbd. Be careful: bitmap for export is is selected during nbd negotiation - actually in open(). So, name argument for qmp block-dirty-bitmap-load is just a _new_ name for loaded bitmap. (any way, for us block-dirty-bitmap-load is just a way to test the feature, really we need only server part)
- get_block_status works now through nbd CMD_BLOCK_STATUS, if base:allocation is negotiated for export.

It should be minimal but fully compatible realization of the spec.

web: https://src.openvz.org/users/vsementsov/repos/qemu/browse?at=nbd-block-status-v1
git: https://src.openvz.org/scm/~vsementsov/qemu.git (tag nbd-block-status-v1)

Vladimir Sementsov-Ogievskiy (18):
nbd: rename NBD_REPLY_MAGIC to NBD_SIMPLE_REPLY_MAGIC
nbd-server: refactor simple reply sending
nbd: Minimal structured read for server
nbd/client: refactor nbd_receive_starttls
nbd/client: fix drop_sync
nbd/client: refactor drop_sync
nbd: Minimal structured read for client
hbitmap: add next_zero function
block/dirty-bitmap: add bdrv_dirty_bitmap_next() block/dirty-bitmap: add bdrv_load_dirty_bitmap
nbd: BLOCK_STATUS for bitmap export: server part
nbd: BLOCK_STATUS for bitmap export: client part
nbd: add nbd_dirty_bitmap_load
qmp: add x-debug-block-dirty-bitmap-sha256
qmp: add block-dirty-bitmap-load
iotests: add test for nbd dirty bitmap export
nbd: BLOCK_STATUS for standard get_block_status function: server part
nbd: BLOCK_STATUS for standard get_block_status function: client part

 block/dirty-bitmap.c                     |  70 ++++
 block/nbd-client.c                       | 230 ++++++++++-
 block/nbd-client.h                       |  13 +
 block/nbd.c                              |  44 +-
 blockdev.c                               |  57 +++
 include/block/block_int.h                |   4 +
 include/block/dirty-bitmap.h             |  10 +
 include/block/nbd.h                      |  73 +++-
 include/qemu/hbitmap.h                   |  16 +
 nbd/client.c                             | 373 ++++++++++++++---
 nbd/nbd-internal.h                       |  25 +-
 nbd/server.c                             | 661 ++++++++++++++++++++++++++++++-
 qapi/block-core.json                     |  46 ++-
 qemu-nbd.c                               |   2 +-
 tests/Makefile.include                   |   2 +-
 tests/qemu-iotests/180                   | 133 +++++++
 tests/qemu-iotests/180.out               |   5 +
 tests/qemu-iotests/group                 |   1 +
 tests/qemu-iotests/nbd-fault-injector.py |   4 +-
 util/hbitmap.c                           |  37 ++
 20 files changed, 1713 insertions(+), 93 deletions(-)
 create mode 100755 tests/qemu-iotests/180
 create mode 100644 tests/qemu-iotests/180.out
Signature · 1 line
2.11.0