Skip to content

bump/choice for qt 5.8.0

Peter Seiderer buildroot 2 versions New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest posting 2/20 of 9 patches 0 repliesNew
  2. v6 posting 1/23 of 9 patches 0 repliesSuperseded

Patches in v6 posting 2/2 No applies recorded yet

None of the 9 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v6 yet.

Read the v6 thread

Cover letter [Buildroot] [PATCH v6 0/9] bump/choice for qt 5.8.0

Hello Arnout,

Quoted 105 lines · Arnout Vandecappelle
Quoted 102 lines · Peter Seiderer

Hello Arnout,

Quoted 82 lines · Arnout Vandecappelle
Quoted 79 lines · Peter Seiderer
Quoted 77 lines · Arnout Vandecappelle
Quoted 44 lines · Andreas Naumann

Hi,

first of all, thanks everybody for taking over and pushing this further. My finding on this below..

Am 06.02.2017 um 16:40 schrieb Thomas Petazzoni:

Quoted 38 lines

Hello,

Quoted 1 line · Zoltan Gyarmati

The Qt 5.8 config (and pyqt5) was tested on Raspberry Pi.

As Arnout said we are trying to apply this patch series (or actually a subset of it). We have already fixed the comments that people have raised, and you can see the result at:

http://git.free-electrons.com/users/thomas-petazzoni/buildroot/log/?h=qt5-bump

Unfortunately, this fails to build with the following defconfig:

BR2_arm=y
BR2_cortex_a8=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_PACKAGE_QT5=y
BR2_PACKAGE_QT5BASE_LICENSE_APPROVED=y
BR2_PACKAGE_QT5DECLARATIVE=y
BR2_PACKAGE_QT5IMAGEFORMATS=y
BR2_PACKAGE_QT5LOCATION=y
BR2_PACKAGE_QT5MULTIMEDIA=y
BR2_PACKAGE_QT5SENSORS=y
BR2_PACKAGE_QT5SERIALBUS=y
BR2_PACKAGE_QT5SVG=y
BR2_PACKAGE_QT5TOOLS=y
BR2_PACKAGE_QT5TOOLS_PIXELTOOL=y
BR2_PACKAGE_QT5TOOLS_QTDIAG=y
BR2_PACKAGE_QT5TOOLS_QTPATHS=y
BR2_PACKAGE_QT5TOOLS_QTPLUGININFO=y
BR2_PACKAGE_QT5WEBCHANNEL=y
BR2_PACKAGE_QT5ENGINIO=y

With the following error message during the qt5base build:

Project ERROR: Library 'libpng' is not defined.

Quoted 8 lines
Quoted 1 line

Could you take our branch, and see why there is this build failure ?

I have tried your branch and defconfig and see the same failure. Unfortunately I have no idea why it happens, I have never observed that problem.

There are reports about these kind of problem, but without a hint for the real reason.
https://bugreports.qt.io/browse/QTBUG-57148

That's something else, it happens while building the bundled freetype which we
don't do.

Quoted 1 line

https://bugreports.qt.io/browse/QTBUG-57794

That one looks like the same issue.

Quoted 4 lines

After fiddling a little, I can get over it by selecting BR2_PACKAGE_QT5BASE_FONTCONFIG. Unfortunately I run out of time debugging further for now.

Since it would be really nice to have Qt5.8 in 2017.02, I wouldn't mind working
around it with

# Not clear why this is needed, the build fails without it select BR2_PACKAGE_QT5BASE_FONTCONFIG if BR2_PACKAGE_QT5_VERSION_LATEST

to BR2_PACKAGE_QT5BASE_PNG. Thomas and I looked at it as well for a little while and couldn't come up with an explanation.

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

It would be good however to report our findings in QTBUG-57794.

QTBUG-57794 points to QTBUG-58038 [1] with fix attached (see [2] and [3]), may be worth a try?

How did I miss that reference!

And the patche worked for me with the given defconfig...

Quoted 5 lines

But that is not the correct fix for us. That fix will make sure that the
bundled freetype is built when the system libpng is selected. But we of course want the system freetype, not the bundled one. QTBUG-58038 will indeed fix the build, but it's not what we want. We need to pass -system-freetype and select BR2_PACKAGE_FREETYPE.

Quoted 6 lines
Quoted 2 lines

I think this would be another improvement fix/patch (can be done on top of the patchset)?

So what you propose is to first commit 5.8 with the patch from QTBUG-58038, and
subsequently add -system-freetype and remove the patch again?

Yes (and no need to remove the patch which fixes a real problem with compiling the bundled freetype library and can for sure be removed with the next version bump to 5.8.1). It is not the cleanest thing to do but fixes the build problem...

Changing from bundled freetype to system freetype is a real enhancement of the buildroot qt5base package (bundled freetype-2.6.1, system freetype-2.7.1) and should be done in an extra patch (even if it fixes/avoids the bundled compile problem)?

For some other libs (eg. sqlite) buildroot supports the system vs. bundled option....in case we support this for freetype the patch needed too...

Regards,
Peter

Quoted 5 lines

Regards,
Arnout

Quoted 1 line

System freetype is not used at the moment (not for 5.6 and 5.8)...