Skip to content

ethtool flow director fixups

Jacob Keller intel-wired-lan 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11i40e: send correct port number to AdminQ when enabling UDP tunnelsdrivers/net/ethernet/intel/i40e/i40e.h drivers/net/ethernet/intel/i40e/i40e_main.c+10 -101 reply
2/11i40e: don't use arrays for (src|dst)_ipdrivers/net/ethernet/intel/i40e/i40e.h drivers/net/ethernet/intel/i40e/i40e_ethtool.c drivers/net/ethernet/intel/i40e/i40e_txrx.c+14 -141 reply
3/11i40e: rework exit flow of i40e_add_fdir_ethtooldrivers/net/ethernet/intel/i40e/i40e_ethtool.c+11 -41 reply
4/11i40e: return immediately when failing to add fdir filterdrivers/net/ethernet/intel/i40e/i40e_txrx.c+14 -191 reply
5/11i40e: exit ATR mode only when adding TCP/IPv4 filter succeedsdrivers/net/ethernet/intel/i40e/i40e_txrx.c+17 -171 reply
6/11i40e: remove redundant check for fd_tcp_rule when restoring filtersdrivers/net/ethernet/intel/i40e/i40e_main.c+0 -61 reply
7/11i40e: reset fd_tcp_rule count when restoring filtersdrivers/net/ethernet/intel/i40e/i40e_main.c+3 -01 reply
8/11i40e: don't re-enable ATR when flushing filters if SB has TCP4/IPv4 rulesdrivers/net/ethernet/intel/i40e/i40e_main.c+1 -11 reply
9/11i40e: add counters for UDP/IPv4 and IPv4 filtersdrivers/net/ethernet/intel/i40e/i40e.h drivers/net/ethernet/intel/i40e/i40e_main.c drivers/net/ethernet/intel/i40e/i40e_txrx.c+34 -111 reply
10/11i40e: explicitly fail on extended MAC field for ethtool_rx_flow_specdrivers/net/ethernet/intel/i40e/i40e_ethtool.c+4 -01 reply
11/11i40e: always remove old filter when adding new FDir filterdrivers/net/ethernet/intel/i40e/i40e_ethtool.c+7 -251 reply

Reviews trailers per patch

4 of 11 patches have a Reviewed-by or Acked-by.

PatchWilliams, Mitch ADayanand, AvinashBrady, AlanAndrew Bowers
1/11R-b T-b
2/11T-b
3/11T-b
4/11R-b R-b R-b T-b
5/11R-b T-b
6/11T-b
7/11T-b
8/11R-b R-b R-b T-b
9/11T-b
10/11T-b
11/11T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [Intel-wired-lan] [PART1 PATCH 00/11] ethtool flow director fixups

This series is PART1 of 2 parts, containing some initial fixups for the ethtool ntuple filter API. The first part should be relatively self-contained and each fix should stand on its own. It is textually necessary for this series to land before PART2 can be applied.

Jacob Keller (11):
i40e: send correct port number to AdminQ when enabling UDP tunnels
i40e: don't use arrays for (src|dst)_ip
i40e: rework exit flow of i40e_add_fdir_ethtool
i40e: return immediately when failing to add fdir filter
i40e: exit ATR mode only when adding TCP/IPv4 filter succeeds
i40e: remove redundant check for fd_tcp_rule when restoring filters
i40e: reset fd_tcp_rule count when restoring filters
i40e: don't re-enable ATR when flushing filters if SB has TCP4/IPv4
rules
i40e: add counters for UDP/IPv4 and IPv4 filters
i40e: explicitly fail on extended MAC field for ethtool_rx_flow_spec
i40e: always remove old filter when adding new FDir filter

 drivers/net/ethernet/intel/i40e/i40e.h         | 16 +++--
 drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 59 ++++++++----------
 drivers/net/ethernet/intel/i40e/i40e_main.c    | 43 +++++++------
 drivers/net/ethernet/intel/i40e/i40e_txrx.c    | 84 ++++++++++++++------------
 4 files changed, 105 insertions(+), 97 deletions(-)
Signature · 1 line
2.12.0.rc0.151.g8a5726c42288