Skip to content

IB/srp bug fixes

Bart Van Assche linux-rdma stable 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest8 patches 23 repliesIn review
  2. v16 of 8 patches 34 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8IB/SRP: Avoid using IB_MR_TYPE_SG_GAPSdrivers/infiniband/ulp/srp/ib_srp.c+3 -819 replies
2/8IB/srp: Avoid that duplicate responses trigger a kernel bugdrivers/infiniband/ulp/srp/ib_srp.c+3 -11 reply
3/8IB/srp: Fix race conditions related to task managementdrivers/infiniband/ulp/srp/ib_srp.c drivers/infiniband/ulp/srp/ib_srp.h+30 -160 replies
4/8IB/srp: Document locking conventionsdrivers/infiniband/ulp/srp/ib_srp.c+5 -00 replies
5/8IB/srp: Make a diagnostic message more informativedrivers/infiniband/ulp/srp/ib_srp.c+3 -20 replies
6/8IB/srp: Improve an error pathdrivers/infiniband/ulp/srp/ib_srp.c+2 -10 replies
7/8IB/core: Add support for draining IB_POLL_DIRECT completion queuesdrivers/infiniband/core/cq.c drivers/infiniband/core/verbs.c+17 -222 replies
8/8IB/srp: Drain the send queue before destroying a QPdrivers/infiniband/ulp/srp/ib_srp.c+14 -50 replies

Reviews trailers per patch

2 of 8 patches have a Reviewed-by or Acked-by.

PatchSteve WiseLeon Romanovsky
1/8
2/8R-b
3/8
4/8
5/8
6/8
7/8R-b R-b
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/8] IB/srp bug fixes

Hello Doug,

The patches in this series are the initiator patches I came up with while testing the SRP initiator and target drivers. Please consider these patches for inclusion in the upstream kernel.

The changes compared to the previous version of this series are:
- Left out the "Use the IB_DEVICE_SG_GAPS_REG HCA feature if supported" patch.
- Added a patch to stop using memory regions with gaps since Laurence ran into an issue with these memory regions that cannot be explained by analzying the SRP initiator code only.
- Addressed Leon's comments about patch "Avoid that duplicate responses trigger a kernel bug" and "Add support for draining IB_POLL_DIRECT completion queues".

The patches in this series are:

Bart Van Assche (8):
IB/SRP: Avoid using IB_MR_TYPE_SG_GAPS
IB/srp: Avoid that duplicate responses trigger a kernel bug IB/srp: Fix race conditions related to task management IB/srp: Document locking conventions
IB/srp: Make a diagnostic message more informative IB/srp: Improve an error path
IB/core: Add support for draining IB_POLL_DIRECT completion queues IB/srp: Drain the send queue before destroying a QP

 drivers/infiniband/core/cq.c        |  4 +-
 drivers/infiniband/core/verbs.c     | 35 ++++++--------
 drivers/infiniband/ulp/srp/ib_srp.c | 92 ++++++++++++++++++++++++-------------
 drivers/infiniband/ulp/srp/ib_srp.h |  1 +
 4 files changed, 77 insertions(+), 55 deletions(-)

Thanks,

Bart.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html