PTP attribute handling cleanup
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest4 patches 4 repliesIn review
- v14 patches 5 repliesSuperseded
Changes in v2 from the cover letter
- added Richard's acked-by to patch #1
- removed use of kmalloc_array in favor of kcalloc in patch #2 at Richard's request
- added a cover letter
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | ptp: do not explicitly set drvdata in ptp_clock_register()drivers/ | +0 | 0 replies | |
| 2/4 | ptp: use kcalloc when allocating arraysdrivers/ | +2 | 0 replies | |
| 3/4 | ptp: use is_visible method to hide unused attributesdrivers/ | +55 | 0 replies | |
| 4/4 | ptp: create "pins" together with the rest of attributesdrivers/ drivers/ drivers/ | +24 | 0 replies |
Reviews trailers per patch
1 of 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Richard Cochran |
|---|---|
| Series | A-b |
| 1/4 | A-b |
| 2/4 | |
| 3/4 | |
| 4/4 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/4] PTP attribute handling cleanup
PTP core was creating some attributes, such as "period" and "fifo", and the entire "pins" attribute group, after creating class deevice, which creates a race for userspace: uevent may arrive before all attributes are created.
This series of patches switches PTP to use is_visible() to control visibility of attributes in a group, and device_create_with_groups() to ensure that attributes are created before we notify userspace of a new device.
v2:
- added Richard's acked-by to patch #1
- removed use of kmalloc_array in favor of kcalloc in patch #2 at Richard's request
- added a cover letter
v1:
- initial patch set
Dmitry Torokhov (4):
ptp: do not explicitly set drvdata in ptp_clock_register()
ptp: use kcalloc when allocating arrays
ptp: use is_visible method to hide unused attributes
ptp: create "pins" together with the rest of attributes
drivers/ptp/ptp_clock.c | 22 +++--- drivers/ptp/ptp_private.h | 7 +- drivers/ptp/ptp_sysfs.c | 167 ++++++++++++++++++---------------------------- 3 files changed, 80 insertions(+), 116 deletions(-)
Thanks.
Signature · 1 line
Dmitry