Skip to content

Moving the common engine/ring code to intel_engine_cs.c

Tvrtko Ursulin intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3drm/i915: Make int __intel_ring_space staticdrivers/gpu/drm/i915/intel_ringbuffer.c drivers/gpu/drm/i915/intel_ringbuffer.h+1 -20 replies
2/3drm/i915: Move common engine and ring code into intel_engine_csdrivers/gpu/drm/i915/intel_engine_cs.c drivers/gpu/drm/i915/intel_ringbuffer.c+834 -8342 replies
2/3drm/i915: Move common workaround code to intel_engine_csdrivers/gpu/drm/i915/intel_engine_cs.c drivers/gpu/drm/i915/intel_ringbuffer.c+550 -5500 replies
3/3drm/i915: Simplify cleanup path in intel_engines_initdrivers/gpu/drm/i915/intel_engine_cs.c+1 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] Moving the common engine/ring code to intel_engine_cs.c

From: Tvrtko Ursulin <[email protected]>

Chris suggested that we should do this but it is a lot of churn so I don't know.

There is more re-org we could do to make things more logical, like maybe move struct intel_ring code to intel_ring.c, but said, I am not sure it is worth the disruption.

Patch 1 and 3 at least are small cleanups on their own.

Tvrtko Ursulin (3):
drm/i915: Make int __intel_ring_space static drm/i915: Move common engine and ring code into intel_engine_cs drm/i915: Simplify cleanup path in intel_engines_init

 drivers/gpu/drm/i915/intel_engine_cs.c  | 838 +++++++++++++++++++++++++++++++-
 drivers/gpu/drm/i915/intel_ringbuffer.c | 834 -------------------------------
 drivers/gpu/drm/i915/intel_ringbuffer.h |   1 -
 3 files changed, 835 insertions(+), 838 deletions(-)
Signature · 6 lines
2.9.3

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx