RFC Regressions due to 7b79d10a2d64 ("mm: convert kmalloc_section_memmap() to populate_section_memmap()") and Kasan initialization on
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest3 patches 8 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | sparse-vmemmap: let vmemmap_populate_basepages() cover the whole rangemm/ | +1 | 0 replies | |
| 2/3 | sparse-vmemmap: make vmemmap_populate_basepages() skip HP mapped rangesmm/ | +12 | 0 replies | |
| 3/3 | sparse-vmemmap: let vmemmap_verify() ignore NUMA_NO_NODE requestsmm/ | +3 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [RFC 0/3] Regressions due to 7b79d10a2d64 ("mm: convert kmalloc_section_memmap() to populate_section_memmap()") and Kasan initialization on
Hi Dan,
your recent commit 7b79d10a2d64 ("mm: convert kmalloc_section_memmap() to populate_section_memmap()") seems to cause some issues with respect to Kasan initialization on x86.
This is because Kasan's initialization (ab)uses the arch provided vmemmap_populate().
The first one is a boot failure, see [1/3]. The commit before the aforementioned one works fine.
The second one, i.e. [2/3], is something that hit my eye while browsing the source and I verified that this is indeed an issue by printk'ing and dumping the page tables.
The third one are excessive warnings from vmemmap_verify() due to Kasan's NUMA_NO_NODE page populations.
I'll be travelling the next two days and certainly not be able to respond or polish these patches any further. Furthermore, the next merge window is close. So please, take these three patches as bug reports only, meant to illustrate the issues. Feel free to use, change and adopt them however you deemed best.
That being said,
- [2/3] will break arm64 due to the current lack of a pmd_large().
- Maybe it's easier and better to restore former behaviour by letting Kasan's shadow initialization on x86 use vmemmap_populate_hugepages() directly rather than vmemmap_populate(). This would require x86_64 implying X86_FEATURE_PSE though. I'm not sure whether this holds, in particular not since the vmemmap_populate() from arch/x86/mm/init_64.c checks for it.
Thanks,
Nicolai
Nicolai Stange (3):
sparse-vmemmap: let vmemmap_populate_basepages() cover the whole range
sparse-vmemmap: make vmemmap_populate_basepages() skip HP mapped
ranges
sparse-vmemmap: let vmemmap_verify() ignore NUMA_NO_NODE requests
mm/sparse-vmemmap.c | 22 ++++++++++++++++------ 1 file changed, 16 insertions(+), 6 deletions(-)
Signature · 7 lines
2.11.1 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>