Skip to content

vmstate: handle arrays with null ptrs

Halil Pasic qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 4 repliesIn review
  2. v15 patches 10 repliesSuperseded

Changes in v2 from the cover letter

* do not ignore return value (Dave)
* change some asserts to report_error+rc (Dave)
* factor out and reuse wire_sample in patches 4 and 5 (Dave)
* minor reword of patch 2
* add r-b's

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5migration/vmstate: renames in (load|save)_statemigration/vmstate.c+11 -110 replies
2/5migration/vmstate: split up vmstate_base_addrmigration/vmstate.c+17 -220 replies
3/5migration/vmstate: fix array of ptr with nullptrsinclude/migration/vmstate.h migration/vmstate.c+42 -23 replies
4/5tests/test-vmstate.c: test array of ptr with nulltests/test-vmstate.c+57 -170 replies
5/5tests/test-vmstate.c: test array of ptr to primitivetests/test-vmstate.c+48 -00 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchDr. David Alan GilbertGuenther Hutzl
1/5R-b
2/5R-b
3/5R-b R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 0/5] vmstate: handle arrays with null ptrs

The objective is supporting migration of arrays of pointers holdig a mix of null and not null pointers.

v1 -> v2:
* do not ignore return value (Dave)
* change some asserts to report_error+rc (Dave)
* factor out and reuse wire_sample in patches 4 and 5 (Dave)
* minor reword of patch 2
* add r-b's

RFC v2 -> v1:
* rebase
* changed marker as suggested by Dave (incl. simplifications)
* fixed issues pointed out by Dave
* reworded some commit messages
* added a test for array of ptr to primitive

Halil Pasic (5):
migration/vmstate: renames in (load|save)_state migration/vmstate: split up vmstate_base_addr migration/vmstate: fix array of ptr with nullptrs tests/test-vmstate.c: test array of ptr with null tests/test-vmstate.c: test array of ptr to primitive

 include/migration/vmstate.h |   4 ++
 migration/vmstate.c         |  97 +++++++++++++++++++++++------------
 tests/test-vmstate.c        | 122 ++++++++++++++++++++++++++++++++++++++------
 3 files changed, 173 insertions(+), 50 deletions(-)
Signature · 1 line
2.8.4