Skip to content

delete_ref: support reflog messages

Kyle Meyer git 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 6 repliesIn review
  2. v13 patches 17 repliesSuperseded

Changes in v2 from the cover letter

* "msg" is now positioned as the first argument to delete_ref() to match update_ref().

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4delete_ref: accept a reflog message argumentbuiltin/am.c builtin/branch.c builtin/notes.c +11 more+22 -223 replies
2/4update-ref: pass reflog message to delete_ref()builtin/update-ref.c t/t1400-update-ref.sh+19 -10 replies
3/4rename_ref: replace empty message in HEAD's logrefs/files-backend.c t/t3200-branch.sh+6 -10 replies
4/4branch: record creation of renamed branch in HEAD's logbranch.c branch.h builtin/branch.c +3 more+15 -100 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by.

PatchJeff King
1/4
2/4
3/4Helped-by
4/4Based-on-patch-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] delete_ref: support reflog messages

Thanks to Junio and Peff for their feedback on v1.

https://public-inbox.org/git/[email protected]/T/#u

Changes from v1:

* "msg" is now positioned as the first argument to delete_ref() to match update_ref().

[email protected]

* A "delete by head" test case has been added for the update-ref change.

[email protected]

* The added tests no longer send grep's output to /dev/null.

[email protected]

* Renaming the current branch is represented by two entries in HEAD's log, both which reuse the log message passed to rename_ref().

[email protected], [email protected]

* Corrected a few places in the commit messages where "delete_refs" was written instead of "delete_ref".

Kyle Meyer (4):
delete_ref: accept a reflog message argument
update-ref: pass reflog message to delete_ref()
rename_ref: replace empty message in HEAD's log
branch: record creation of renamed branch in HEAD's log

 branch.c               |  5 +++--
 branch.h               |  3 ++-
 builtin/am.c           |  4 ++--
 builtin/branch.c       |  7 ++++---
 builtin/notes.c        |  4 ++--
 builtin/remote.c       |  4 ++--
 builtin/replace.c      |  2 +-
 builtin/reset.c        |  2 +-
 builtin/symbolic-ref.c |  2 +-
 builtin/tag.c          |  2 +-
 builtin/update-ref.c   |  2 +-
 fast-import.c          |  2 +-
 refs.c                 |  6 +++---
 refs.h                 |  7 ++++---
 refs/files-backend.c   | 10 +++++-----
 t/t1400-update-ref.sh  | 18 ++++++++++++++++++
 t/t3200-branch.sh      |  6 ++++++
 transport.c            |  2 +-
 18 files changed, 58 insertions(+), 30 deletions(-)
Signature · 1 line
2.11.1