Skip to content

tools/kvm_stat: Misc Patches

Stefan Raspl kvm 2 versions – Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest17 patches 5 repliesApplied
  2. v117 patches 17 repliesSuperseded

Changes in v2 from the cover letter

- 04/17: Removed chunk that eliminated the only once used libc variable,

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/17tools/kvm_stat: hide cursortools/kvm/kvm_stat/kvm_stat+7 -00 replies
2/17tools/kvm_stat: catch curses exceptions onlytools/kvm/kvm_stat/kvm_stat+1 -10 replies
3/17tools/kvm_stat: handle SIGINT in log and batch modestools/kvm/kvm_stat/kvm_stat+17 -111 reply
4/17tools/kvm_stat: fix misc glitchestools/kvm/kvm_stat/kvm_stat+11 -130 replies
5/17tools/kvm_stat: fix trace setup glitch on field updates in TracepointProvidertools/kvm/kvm_stat/kvm_stat+3 -20 replies
6/17tools/kvm_stat: full PEP8 compliancetools/kvm/kvm_stat/kvm_stat+22 -00 replies
7/17tools/kvm_stat: reduce perceived idle time on filter updatestools/kvm/kvm_stat/kvm_stat+30 -180 replies
8/17tools/kvm_stat: document list of interactive commandstools/kvm/kvm_stat/kvm_stat tools/kvm/kvm_stat/kvm_stat.txt+23 -00 replies
9/17tools/kvm_stat: display guest name when using pid filtertools/kvm/kvm_stat/kvm_stat+39 -20 replies
10/17tools/kvm_stat: remove pid filter on empty inputtools/kvm/kvm_stat/kvm_stat+7 -40 replies
11/17tools/kvm_stat: print error messages on faulty pid filter inputtools/kvm/kvm_stat/kvm_stat+4 -00 replies
12/17tools/kvm_stat: display regex when set to non-defaulttools/kvm/kvm_stat/kvm_stat+6 -00 replies
13/17tools/kvm_stat: remove regex filter on empty inputtools/kvm/kvm_stat/kvm_stat+1 -00 replies
14/17tools/kvm_stat: add option '--guest'tools/kvm/kvm_stat/kvm_stat tools/kvm/kvm_stat/kvm_stat.txt+105 -20 replies
15/17tools/kvm_stat: add interactive command 'c'tools/kvm/kvm_stat/kvm_stat tools/kvm/kvm_stat/kvm_stat.txt+14 -40 replies
16/17tools/kvm_stat: add interactive command 'r'tools/kvm/kvm_stat/kvm_stat tools/kvm/kvm_stat/kvm_stat.txt+53 -141 reply
17/17tools/kvm_stat: add '%Total' columntools/kvm/kvm_stat/kvm_stat+8 -11 reply

Reviews trailers per patch

13 of 17 patches have a Reviewed-by or Acked-by.

PatchJanosch FrankMarc HartmayerSascha Silbe
1/17R-b R-b
2/17R-b R-b R-b
3/17R-b
4/17R-b
5/17Based-on-text-by
6/17R-b
7/17
8/17
9/17R-b
10/17R-b R-b
11/17R-b
12/17R-b
13/17R-b
14/17R-b
15/17R-b
16/17A-b
17/17

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 00/17] tools/kvm_stat: Misc Patches

Assortment of various fixes and improvements for the kvm_stat utility. Patches 1-5 are bugfixes.
Patch 6 provides full PEP8 compliance by inserting the required empty lines. It is included as an extra for easy disposal, since that kind of patch might be a bit controversial.
There are some subtle aspects regarding patch 7, as its effects might differ per platform. However, I didn't notice any negative effects, only improvements.
Patch 8 is a simple doc update.
Patches 9-13 provide usability improvements.
Patches 14-17 add new features.

Changes in v2:
- 04/17: Removed chunk that eliminated the only once used libc variable,

         and changed '3.' -> '3.0'

- 07/17: Changed '3.' -> '3.0'
- 16/17: Fixed accidental removal of description for interactive command 'x'

Stefan Raspl (17):
tools/kvm_stat: hide cursor
tools/kvm_stat: catch curses exceptions only tools/kvm_stat: handle SIGINT in log and batch modes tools/kvm_stat: fix misc glitches
tools/kvm_stat: fix trace setup glitch on field updates in
TracepointProvider
tools/kvm_stat: full PEP8 compliance
tools/kvm_stat: reduce perceived idle time on filter updates tools/kvm_stat: document list of interactive commands tools/kvm_stat: display guest name when using pid filter tools/kvm_stat: remove pid filter on empty input tools/kvm_stat: print error messages on faulty pid filter input tools/kvm_stat: display regex when set to non-default tools/kvm_stat: remove regex filter on empty input tools/kvm_stat: add option '--guest'
tools/kvm_stat: add interactive command 'c' tools/kvm_stat: add interactive command 'r' tools/kvm_stat: add '%Total' column

 tools/kvm/kvm_stat/kvm_stat     | 381 +++++++++++++++++++++++++++++++++-------
 tools/kvm/kvm_stat/kvm_stat.txt |  26 +++
 2 files changed, 343 insertions(+), 64 deletions(-)
Signature · 1 line
2.8.4