Skip to content

batman-adv: cleanups patches for Linux 4.12

Sven Eckelmann batman 2 versions – In review

Get series with b4
b4 am 82659786.7iirk8N2EY@bentobox

Versions newest first · linked by author and title

  1. v2 Latest4 patches 1 replyIn review
  2. v12 patches 0 repliesSuperseded

Changes in v2 from the cover letter

* rebased on top of master
* split "Fix possible side-effects in macros" in two patches
* converted BATADV_PRINT_VID to an inline function

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4batman-adv: Remove preprocessor checks in multicast.cnet/batman-adv/multicast.c+6 -100 replies
2/4batman-adv: Fix unbalanced braces around else statementnet/batman-adv/translation-table.c+4 -20 replies
3/4batman-adv: Fix possible side-effects in _batadv_dbgnet/batman-adv/log.h+3 -20 replies
4/4batman-adv: Convert BATADV_PRINT_VID macro to functionnet/batman-adv/bridge_loop_avoidance.c net/batman-adv/distributed-arp-table.c net/batman-adv/main.h +1 more+54 -420 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [B.A.T.M.A.N.] [PATCH v2 0/4] batman-adv: cleanups patches for Linux 4.12

Hi,

here is the second version of cleanup patches. It addresses a couple of new checks from checkpatch.pl:

* CHECK: Macro argument reuse '%s' - possible side-effects?
* CHECK: Unbalanced braces around else statement

The last check currently creates a lot of false positives but a fix for it was already submitted to Andrew Morton (+ accepted).

It also contains a patch which converts the preprocessor blocks in multicast.c to simple inline checks. The compiler can directly take care of removing the unused code when some CONFIG_* option disabled.

changes in v2:

* rebased on top of master
* split "Fix possible side-effects in macros" in two patches
* converted BATADV_PRINT_VID to an inline function

Kind regards,
Sven

Sven Eckelmann (4):
batman-adv: Remove preprocessor checks in multicast.c
batman-adv: Fix unbalanced braces around else statement
batman-adv: Fix possible side-effects in _batadv_dbg
batman-adv: Convert BATADV_PRINT_VID macro to function

 net/batman-adv/bridge_loop_avoidance.c | 38 +++++++++++++++---------------
 net/batman-adv/distributed-arp-table.c |  6 ++---
 net/batman-adv/log.h                   |  5 ++--
 net/batman-adv/main.h                  | 16 +++++++++++--
 net/batman-adv/multicast.c             | 16 +++++--------
 net/batman-adv/translation-table.c     | 42 ++++++++++++++++++----------------
 6 files changed, 67 insertions(+), 56 deletions(-)