Skip to content

kuser updates for ARM-only vs Thumb

Martin Kaiser linux-arm-kernel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 4 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 4 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] kuser updates for ARM-only vs Thumb

Thus wrote Russell King - ARM Linux (linux at armlinux.org.uk):

Quoted 9 lines

A while back, an issue was raised about the return instruction used in the kuser page when building an ARMv4 and later environment.

In order to fix this, I suggested building the kuser code for both variants and selecting the appropriate version at run time. This seemed to be a simple solution, but due to the fix-ups and need to build the appropriate version for the Kconfig options selected, turned out to be not quite as trivial as I hoped.

Quoted 5 lines

Nevertheless, this patch series provides that solution.

As a side effect of this, the first patch is one which should be merged irrespective of the remainder as it provides a useful cleanup to the large number of dependencies for the ARM_THUMB option.

Since this was merged (commit bf4b17749f8632696134c8705f294ce02c85c1fa), linux-next would stop working on my imx258 (ARM926T).

Kernel panic - not syncing: Attempted to kill init!  exitcode=0x00000004

It turned out that CONFIG_ARM_THUMB was not set in my kernel config, enabling it fixed the problem.

Does this mean the kuser helpers now use thumb instructions and a user space binary crashes when it uses the helpers and thumb binaries are not supported?

If CONFIG_CPU_THUMB_CAPABLE requires CONFIG_ARM_THUMB, should we make this more explicit in the code?

Thanks,
Martin