Skip to content

xenstore: enhance runtime debug capabilities

Juergen Gross xen-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest6 patches 1 replyIn review
  2. v37 patches 8 repliesSuperseded
  3. v25 patches 12 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v14 patches3 repliesSuperseded

Changes in v4 from the cover letter

- Removed patch 1 as already applied
- Patch 3 (was 4): add missing free(), use goto-style error handling, xs_debug_command() -> xs_control_command() (all Wei Liu)

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6xenstore: rename XS_DEBUG wire commandtools/xenstore/include/xenstore.h tools/xenstore/xenstored_core.c tools/xenstore/xs.c +1 more+18 -100 replies
2/6xenstore: Split out XS_CONTROL action to dedicated source filetools/xenstore/Makefile tools/xenstore/xenstored_control.c tools/xenstore/xenstored_control.h +2 more+71 -270 replies
3/6xenstore: enhance control command supporttools/xenstore/xenstore_control.c tools/xenstore/xenstored_control.c+140 -301 reply
4/6xenstore: add support for changing log functionality dynamicallytools/xenstore/xenstored_control.c tools/xenstore/xenstored_core.c tools/xenstore/xenstored_core.h+48 -40 replies
5/6xenstore: make memory report available via XS_CONTROLtools/xenstore/xenstored_control.c tools/xenstore/xenstored_core.c tools/xenstore/xenstored_core.h+42 -10 replies
6/6xenstore: remove memory report command line supporttools/xenstore/xenstored_core.c+2 -330 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchWei Liu
1/6R-b
2/6R-b
3/6R-b
4/6R-b
5/6R-b
6/6A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/6] xenstore: enhance runtime debug capabilities

Today xenstored supports logging only via a command line parameter. This means that logging is either all the time off (default) or on. To switch logging on the Xen host has to be rebooted as xenstored isn't restartable.

This patch series changes this by using the XS_DEBUG wire command of Xenstore to control various debug functions:

- switch logging on/off
- specify logfile to use
- write memory usage to file

This will enable the host administrator to control above functionality without the need of specifying any additional command line parameters of xenstored or to restart the host in case of debug information needed.

Changes in V4:
- Removed patch 1 as already applied
- Patch 3 (was 4): add missing free(), use goto-style error handling, xs_debug_command() -> xs_control_command() (all Wei Liu)

Changes in V3:
- Added new patch 1: fix a bug in reopen_log() (Wei Liu)
- Patch 2 (was 1): add xs_control_command() to libxenstore (Wei Liu)
- Split old patch 2 into two patches (Wei Liu)
- Add comment to patch 6 (was 4) (Wei Liu)

Changes in V2:
- added new patch 1 (rename of XS_DEBUG to XS_CONTROL)

Juergen Gross (6):
xenstore: rename XS_DEBUG wire command
xenstore: Split out XS_CONTROL action to dedicated source file
xenstore: enhance control command support
xenstore: add support for changing log functionality dynamically
xenstore: make memory report available via XS_CONTROL
xenstore: remove memory report command line support

 tools/xenstore/Makefile            |   4 +-
 tools/xenstore/include/xenstore.h  |   4 +-
 tools/xenstore/xenstore_control.c  |  70 +++++++++----
 tools/xenstore/xenstored_control.c | 198 +++++++++++++++++++++++++++++++++++++
 tools/xenstore/xenstored_control.h |  19 ++++
 tools/xenstore/xenstored_core.c    |  81 ++++-----------
 tools/xenstore/xenstored_core.h    |   6 +-
 tools/xenstore/xs.c                |  13 ++-
 xen/include/public/io/xs_wire.h    |   3 +-
 9 files changed, 307 insertions(+), 91 deletions(-)
 create mode 100644 tools/xenstore/xenstored_control.c
 create mode 100644 tools/xenstore/xenstored_control.h
Signature · 7 lines
2.10.2


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xen.org/xen-devel