Skip to content

nfs/nfsd/sunrpc: enforce requirement for congestion control protocols in NFSv4

Jeff Layton linux-nfs linux-rdma 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 14 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4sunrpc: flag transports as using IETF approved congestion control protocolsinclude/linux/sunrpc/svc_xprt.h net/sunrpc/svcsock.c net/sunrpc/xprtrdma/svc_rdma_transport.c+4 -013 replies
2/4sunrpc: turn bitfield flags in svc_version into boolsfs/nfs/callback_xdr.c fs/nfsd/nfs2acl.c fs/nfsd/nfs3acl.c +3 more+9 -100 replies
3/4nfs/nfsd/sunrpc: enforce congestion control protocol requirement for NFSv4fs/nfs/callback_xdr.c fs/nfsd/nfs4proc.c include/linux/sunrpc/svc.h +1 more+25 -60 replies
4/4sunrpc: don't register UDP port with rpcbind when version needs congestion controlnet/sunrpc/svc.c+7 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] nfs/nfsd/sunrpc: enforce requirement for congestion control protocols in NFSv4

RFC5661 says:

Where an NFSv4.1 implementation supports operation over the IP network protocol, any transport used between NFS and IP MUST be among the IETF-approved congestion control transport protocols.

...and RFC7530 has similar verbiage. The NFS server has never enforced this requirement, however, so a user could issue NFSv4 calls against the server via UDP.

This patchset adds a small bit of infrastructure to the sunrpc layer to enforce this requirement, and has the nfs and nfsd layers set the appropriate flags for it. It also has knfsd skip registering a UDP port for NFSv4, using the same flags.

Lightly tested by hand, but it's fairly straightforward.

Jeff Layton (4):
sunrpc: flag transports as using IETF approved congestion control
protocols
sunrpc: turn bitfield flags in svc_version into bools nfs/nfsd/sunrpc: enforce congestion control protocol requirement for
NFSv4
sunrpc: don't register UDP port with rpcbind when version needs
congestion control

 fs/nfs/callback_xdr.c                    |  6 ++++--
 fs/nfsd/nfs2acl.c                        |  1 -
 fs/nfsd/nfs3acl.c                        |  1 -
 fs/nfsd/nfs4proc.c                       | 13 +++++++------
 include/linux/sunrpc/svc.h               | 12 ++++++++----
 include/linux/sunrpc/svc_xprt.h          |  1 +
 net/sunrpc/svc.c                         | 22 +++++++++++++++++++++-
 net/sunrpc/svcsock.c                     |  1 +
 net/sunrpc/xprtrdma/svc_rdma_transport.c |  2 ++
 9 files changed, 44 insertions(+), 15 deletions(-)
Signature · 1 line
2.9.3