Skip to content

recursing submodules with relative pathspec (grep and ls-files)

Brandon Williams git 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 15 repliesIn review
  2. v24 patches 7 repliesSuperseded
  3. v15 patches 8 repliesSuperseded

Changes in v3 from the cover letter

* Added sign-off to the patches where it was missing.
* slight tweak to the style and commit msgs of a few patches.
* broke up the last patch (for ls-files) into a typo fix followed by fixing the bug itself. This was to make the diff easier to review.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5grep: fix help text typobuiltin/grep.c+1 -10 replies
2/5setup: allow for prefix to be passed to git commandscache.h git.c setup.c+7 -312 replies
3/5grep: fix bug when recursing with relative pathspecbuiltin/grep.c t/t7814-grep-recurse-submodules.sh+99 -153 replies
4/5ls-files: fix typo in variable namebuiltin/ls-files.c+8 -80 replies
5/5ls-files: fix bug when recursing with relative pathspecbuiltin/ls-files.c t/t3007-ls-files-recurse-submodules.sh+52 -120 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/5] recursing submodules with relative pathspec (grep and ls-files)

Changes in v3:
* Added sign-off to the patches where it was missing.
* slight tweak to the style and commit msgs of a few patches.
* broke up the last patch (for ls-files) into a typo fix followed by fixing the bug itself. This was to make the diff easier to review.

Brandon Williams (5):
grep: fix help text typo
setup: allow for prefix to be passed to git commands
grep: fix bug when recursing with relative pathspec
ls-files: fix typo in variable name
ls-files: fix bug when recursing with relative pathspec

 builtin/grep.c                         | 41 +++++++++++--------
 builtin/ls-files.c                     | 41 ++++++++++---------
 cache.h                                |  1 +
 git.c                                  |  2 -
 setup.c                                |  7 +++-
 t/t3007-ls-files-recurse-submodules.sh | 39 ++++++++++++++++++
 t/t7814-grep-recurse-submodules.sh     | 75 ++++++++++++++++++++++++++++++++++
 7 files changed, 167 insertions(+), 39 deletions(-)
Signature · 1 line
2.12.0.367.g23dc2f6d3c-goog