Skip to content

some migration bugs

Vladimir Sementsov-Ogievskiy qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 27 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4iotests: add migration corner cases testtests/qemu-iotests/175 tests/qemu-iotests/175.out tests/qemu-iotests/group+77 -02 replies
2/4qmp-cont: invalidate on RUN_STATE_PRELAUNCHqmp.c+2 -16 replies
3/4savevm: fix savevm after migrationblock/snapshot.c migration/savevm.c+13 -115 replies
4/4migration: fix use-after-free of to_dst_filemigration/savevm.c+5 -02 replies

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by.

PatchDr. David Alan GilbertFam Zheng
1/4
2/4R-b
3/4
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/4] some migration bugs

Hi all!

Here are some migration related bugs, two about INACTIVE bdses and one use-after-free.

I'm absolutely not sure, that these bugs should be fixed like I'm fixing, but problem definitely exists.

Reset in stopped state is strange case, may be such usage should be restricted.
About INACTIVE - looks like it should be a separate run-state, not only bdrv-flag.
Situation with migration state, which is global, but is set/reset/changed in not controlled manner is not very good too..

Vladimir Sementsov-Ogievskiy (4):
iotests: add migration corner cases test
qmp-cont: invalidate on RUN_STATE_PRELAUNCH
savevm: fix savevm after migration
migration: fix use-after-free of to_dst_file

 block/snapshot.c           |  3 +-
 migration/savevm.c         | 16 +++++++++++
 qmp.c                      |  3 +-
 tests/qemu-iotests/175     | 71 ++++++++++++++++++++++++++++++++++++++++++++++
 tests/qemu-iotests/175.out |  5 ++++
 tests/qemu-iotests/group   |  1 +
 6 files changed, 97 insertions(+), 2 deletions(-)
 create mode 100644 tests/qemu-iotests/175
 create mode 100644 tests/qemu-iotests/175.out
Signature · 1 line
2.11.1