package/cmake: revert the bump to 3.7
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest0 of 4 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 4 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [Buildroot] [PATCH 0/4] package/cmake: revert the bump to 3.7
Baruch, All,
On 2017-02-25 22:44 +0200, Baruch Siach spake thusly:
Quoted 12 lines · Yann E. MORIN
Quoted 11 lines
cmake 3.7 causes serious regressions in some cmake-based packages, related to how RPATH is handled.
See for example:
- domoticz : http://autobuild.buildroot.org/results/fd0/fd0ba54c7abf973691b39a0ca1bb4e07d749593a/
- freerdp : http://autobuild.buildroot.org/results/5d4/5d429d0e288754a541ee5d8be515454c5fccd28b/
- libcec : http://autobuild.buildroot.org/results/3f3/3f3593bab7734dd274faf5b5690895e9424cbb89/(and many others)
Quoted 8 lines
Quoted 5 lines
All causes the link to be attemped against host libraries, which is definitely not appropriate...
Properly fixing this so close to the release is problematic; we'd risk having to hunt down packages one by one.
What about host installed cmake? Maybe do something like the following (untested) to blacklist version 3.7.x?
Good catch, indeed.
support/dependencies/check-host-cmake.sh version="$(${cmake} --version \ · line 31
Quoted 10 lines
support/dependencies/check-host-cmake.sh +2
-0@@ -27,6 +27,10 @@ version="$(${cmake} --version \ major="${version%.*}" minor="${version#*.}" +if [ ${version} = 3.7 ]; then + exit 1
Minor nit: the rest of the script uses leading spaces.
Also, we should probably catch >= 3.7, no?
Regards,
Yann E. MORIN.
Quoted 12 lines
support/dependencies/check-host-cmake.sh +2
-0+fi + if [ ${major} -gt ${major_min} ]; then echo "${cmake}" elsebaruch
Signature · 3 lines
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'