Skip to content

package/cmake: revert the bump to 3.7

Yann E. MORIN buildroot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 4 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 4 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Buildroot] [PATCH 0/4] package/cmake: revert the bump to 3.7

J?rg, All,

On 2017-02-26 09:44 +0100, J?rg Krause spake thusly:

Quoted 8 lines · Yann E. MORIN
Quoted 4 lines

Hello All!

cmake 3.7 causes serious regressions in some cmake-based packages, related to how RPATH is handled.

For an explanation what's going wrong please have a look at [1].
[1] http://lists.busybox.net/pipermail/buildroot/2017-February/183579.html

Are you sure this is related? The code you point to in this mail should not be executed in cross-compilation:

if(NOT CMAKE_CROSSCOMPILING AND EXISTS "/etc/debian_version")
set_property(GLOBAL PROPERTY FIND_LIBRARY_USE_LIB32_PATHS FALSE) set_property(GLOBAL PROPERTY FIND_LIBRARY_USE_LIB64_PATHS FALSE)
endif()

So, if this code is indeed the culprit, then it eans that CMAKE_CROSSCOMPILING is not set, and that in turn is probably the real issue.

(But I only had one coffee since I woke up, so I may have missed something...)

Regards,
Yann E. MORIN.

Quoted 32 lines
Quoted 10 lines

See for example:

? - domoticz : http://autobuild.buildroot.org/results/fd0/fd0ba54c7ab
f973691b39a0ca1bb4e07d749593a/
? - freerdp??: http://autobuild.buildroot.org/results/5d4/5d429d0e288
754a541ee5d8be515454c5fccd28b/
? - libcec???: http://autobuild.buildroot.org/results/3f3/3f3593bab77
34dd274faf5b5690895e9424cbb89/

(and many others)

For example bctoolbox. Although the build errors are fixed, CMake does not find the optionally mbedTLS package if zlib is available as it links against the host zlib when using check_symbol_exists().

Quoted 6 lines

All causes the link to be attemped against host libraries, which is definitely not appropriate...

Properly fixing this so close to the release is problematic; we'd risk
having to hunt down packages one by one.

A fix which worked for me was to remove the line set(CMAKE_SYSTEM_NAME Linux) from the toolchainfile to be able to set the flag FIND_LIBRARY_USE_LIB32_PATHS property to FALSE. Of course, we also have to set the necessary flags which are set depending on CMAKE_SYSTEM_NAME. However, reverting CMake is probably much cleaner.

[1] http://lists.busybox.net/pipermail/buildroot/2017-February/183579.h
tml
[2] https://git.buildroot.net/buildroot/tree/support/misc/toolchainfile
.cmake.in#n13

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'