Skip to content

classes: rockchip-gpt-img: add

Trevor Woerner yocto 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest1 patch 1 replyIn review
  2. v4 posting 2/20 of 1 patch 0 repliesSuperseded
  3. v4 posting 1/21 patch 3 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v31 patch1 replySuperseded

Changes in v5 from the cover letter

- in addition to generating a -gpt.img (and creating a simpler symlink to it) also create a -boot.img in the deploy directory and create a simpler symlink to it for each build

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1classes: rockchip-gpt-img: addclasses/rockchip-gpt-img.bbclass+143 -00 replies

Reviews trailers per patch

The patch has no Reviewed-by or Acked-by.

PatchEddie Cai
1/1Reviewd-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [meta-rockchip][PATCH v5 0/1] classes: rockchip-gpt-img: add

Here is my v5 of this patch, based on feedback from earlier reviews.

Changes since v4:
- in addition to generating a -gpt.img (and creating a simpler symlink to it) also create a -boot.img in the deploy directory and create a simpler symlink to it for each build

Changes since v3:
- I sent the wrong file when emailing v3

Changes since v2:
- change commit message and call the "old" layout "legacy parameter" format instead of "rk-boot" format
- rename generate_rk3288_image() to generate_rk3288_loader1_image()
- leave any older gpt image files (with datestamp) in the deploy directory but just move the symlink so it always points to the most recent

- leave size variable as GPTIMG_SIZE
- leave the boot image name as BOOT_IMG since trying to add ${MACHINE} and ${DATETIME} causes the build to fail with "the basehash value changed... metadata is not deterministic...". I think what was wanted was that older gpt image files be left around, and this new logic does that in a different way and maintains a symlink to the latest

Changes since v1:
- break large commits into smaller ones
- rename the class and improve the commit message

Trevor Woerner (1):
classes: rockchip-gpt-img: add

 classes/rockchip-gpt-img.bbclass | 143 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 143 insertions(+)
 create mode 100644 classes/rockchip-gpt-img.bbclass
Signature · 1 line
2.12.0.rc1.48.g076c053

Read the cover letter in its thread