package/cmake: re-introduce cmake-3.7
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest1 of 5 patches 0 repliesNew
1 of 5 patches is in this archive. The cover letter announces 5.
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | core/pkg-cmake: provide our own platform description | +0 | 5 replies |
Reviews trailers per patch
The patch has a Reviewed-by or Acked-by.
| Patch | Arnout Vandecappelle (Essensium/Mind) |
|---|---|
| 1/5 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Buildroot] [PATCH 0/5] package/cmake: re-introduce cmake-3.7
Hello,
Quoted 6 lines · Arnout Vandecappelle
I don't think it makes much sense to keep the 4 separate patches. The history
shows the authorship of the original bump. Having the 4 separate patches just adds noise to the history. Also, Thomas reported that the libuv dependency introduced by the bump is probably incorrect, so we'd have to revert patch 4/5 and part of patch 2/5 again later on... And if the dependency on libuv *is* needed, then you re-introduce a non-bisectable commit between patch 2/5 and 4/5.
Well, the libuv dependency is incorrect in the sense that ctest doesn't seem to use libuv.
*However*, the libuv dependency is correct in the sense that the CMakeLists.txt checks it, and if not, builds the cmake built-in version of libuv. But since for the target we only build ctest, this whole libuv is not used.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com