Skip to content

hw/arm/exynos: Minor cleanups

Krzysztof Kozlowski qemu-arm qemu-devel 3 versions – Applied

Status from this message: Applied to target-arm.next for 2.10, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 3 repliesApplied
  2. v23 patches 1 replySuperseded
  3. v13 patches 14 repliesSuperseded

Changes in v3 from the cover letter

================
1. Patch 1/3: Address Eric's comment.
2. Patch 2/3: Address Peter's comments about "const".
3. Patch 3/3: Use "unsigned int". I had impression that no consensus was reached during discussion. If that is wrong impression, let me know.

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/3hw/arm/exynos: Convert fprintf to qemu_log_mask/error_reporthw/arm/exynos4_boards.c hw/timer/exynos4210_mct.c hw/timer/exynos4210_pwm.c +1 more+24 -201 reply
2/3hw/char/exynos4210_uart: Constify static array and few argumentshw/char/exynos4210_uart.c+4 -40 replies
3/3hw/misc/exynos4210_pmu: Reorder local variables for readabilityhw/misc/exynos4210_pmu.c+2 -21 reply

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-Daudé
1/3R-b
2/3
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [Qemu-arm] [PATCH v3 0/3] hw/arm/exynos: Minor cleanups

Hi,

Minor cleanups, no dependencies.

Changes since v1
================
1. Patch 1/3: Address missed Philippe's comments about error reporting verbosity.

Changes since v2
================
1. Patch 1/3: Address Eric's comment.
2. Patch 2/3: Address Peter's comments about "const".
3. Patch 3/3: Use "unsigned int". I had impression that no consensus was reached during discussion. If that is wrong impression, let me know.

Best regards,
Krzysztof

Krzysztof Kozlowski (3):
hw/arm/exynos: Convert fprintf to qemu_log_mask/error_report hw/char/exynos4210_uart: Constify static array and few arguments hw/misc/exynos4210_pmu: Reorder local variables for readability

 hw/arm/exynos4_boards.c   |  6 +++---
 hw/char/exynos4210_uart.c |  8 ++++----
 hw/misc/exynos4210_pmu.c  |  4 ++--
 hw/timer/exynos4210_mct.c |  6 ++++--
 hw/timer/exynos4210_pwm.c | 13 +++++++------
 hw/timer/exynos4210_rtc.c | 19 ++++++++++---------
 6 files changed, 30 insertions(+), 26 deletions(-)
Signature · 1 line
2.9.3