Skip to content

RFC pic/ioapic/irqchip cleanups + minor fixes

David Hildenbrand kvm 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest21 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/21KVM: x86: race between KVM_SET_GSI_ROUTING and KVM_CREATE_IRQCHIPvirt/kvm/kvm_main.c+3 -00 replies
2/21KVM: x86: check against irqchip_mode in kvm_set_routing_entry()arch/x86/include/asm/kvm_host.h arch/x86/kvm/irq.h arch/x86/kvm/irq_comm.c +1 more+12 -75 replies
3/21KVM: x86: check against irqchip_mode in pic_in_kernel()arch/x86/kvm/irq.h+1 -40 replies
4/21KVM: x86: check against irqchip_mode in ioapic_in_kernel()arch/x86/kvm/ioapic.h+1 -40 replies
5/21KVM: x86: get rid of pic_irqchip()arch/x86/kvm/i8259.c arch/x86/kvm/irq.c arch/x86/kvm/irq.h +2 more+16 -230 replies
6/21KVM: x86: get rid of ioapic_irqchip()arch/x86/kvm/ioapic.c arch/x86/kvm/ioapic.h+2 -70 replies
7/21KVM: x86: use ioapic_in_kernel() to check for ioapic existencearch/x86/kvm/ioapic.c+1 -30 replies
8/21KVM: x86: remove duplicate checks for ioapicarch/x86/kvm/ioapic.c+0 -40 replies
9/21KVM: x86: convert kvm_(set|get)_ioapic() into voidarch/x86/kvm/ioapic.c arch/x86/kvm/ioapic.h arch/x86/kvm/x86.c+6 -80 replies
10/21KVM: x86: don't take kvm->irq_lock when creating IRQCHIParch/x86/kvm/x86.c+0 -20 replies
11/21KVM: x86: push usage of slots_lock downarch/x86/kvm/i8259.c arch/x86/kvm/ioapic.c arch/x86/kvm/x86.c+4 -40 replies
12/21KVM: x86: KVM_IRQCHIP_PIC_MASTER only has 8 pinsarch/x86/kvm/irq_comm.c+6 -90 replies
13/21KVM: x86: remove all-vcpu request from kvm_ioapic_init()arch/x86/kvm/ioapic.c+0 -20 replies
14/21KVM: x86: directly call kvm_make_scan_ioapic_request() in ioapic.carch/x86/kvm/ioapic.c+2 -20 replies
15/21KVM: x86: rename kvm_vcpu_request_scan_ioapic()arch/x86/kvm/ioapic.c include/linux/kvm_host.h virt/kvm/eventfd.c+5 -50 replies
16/21KVM: x86: drop goto label in kvm_set_routing_entry()arch/x86/kvm/irq_comm.c+7 -110 replies
17/21KVM: x86: simplify pic_unlock()arch/x86/kvm/i8259.c+3 -80 replies
18/21KVM: x86: make kvm_pic_reset() staticarch/x86/kvm/i8259.c arch/x86/kvm/irq.h+1 -30 replies
19/21KVM: x86: drop picdev_in_range()arch/x86/kvm/i8259.c+12 -230 replies
20/21KVM: x86: set data directly in picdev_read()arch/x86/kvm/i8259.c+3 -40 replies
21/21KVM: x86: simplify pic_ioport_read()arch/x86/kvm/i8259.c+3 -60 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH RFC 00/21] pic/ioapic/irqchip cleanups + minor fixes

My attempt to further cleanup pic/ioapic checks using irqchip_mode + other cleanups in that area.

The goal is to only check against irqchip_mode and not to rely on vpic/vioapic variables anymore to test for existence of pic/ioapic. This will avoid any possible races when creating the kernel irqchip fails.

Feel free to nack if a a certain cleanup is not worth it.

David Hildenbrand (21):
KVM: x86: race between KVM_SET_GSI_ROUTING and KVM_CREATE_IRQCHIP
KVM: x86: check against irqchip_mode in kvm_set_routing_entry()
KVM: x86: check against irqchip_mode in pic_in_kernel()
KVM: x86: check against irqchip_mode in ioapic_in_kernel()
KVM: x86: get rid of pic_irqchip()
KVM: x86: get rid of ioapic_irqchip()
KVM: x86: use ioapic_in_kernel() to check for ioapic existence
KVM: x86: remove duplicate checks for ioapic
KVM: x86: convert kvm_(set|get)_ioapic() into void
KVM: x86: don't take kvm->irq_lock when creating IRQCHIP
KVM: x86: push usage of slots_lock down
KVM: x86: KVM_IRQCHIP_PIC_MASTER only has 8 pins
KVM: x86: remove all-vcpu request from kvm_ioapic_init()
KVM: x86: directly call kvm_make_scan_ioapic_request() in ioapic.c
KVM: x86: rename kvm_vcpu_request_scan_ioapic()
KVM: x86: drop goto label in kvm_set_routing_entry()
KVM: x86: simplify pic_unlock()
KVM: x86: make kvm_pic_reset() static
KVM: x86: drop picdev_in_range()
KVM: x86: set data directly in picdev_read()
KVM: x86: simplify pic_ioport_read()

 arch/x86/include/asm/kvm_host.h |  1 +
 arch/x86/kvm/i8259.c            | 70 +++++++++++++++--------------------------
 arch/x86/kvm/ioapic.c           | 28 ++++++-----------
 arch/x86/kvm/ioapic.h           | 14 ++-------
 arch/x86/kvm/irq.c              |  2 +-
 arch/x86/kvm/irq.h              | 20 +++++-------
 arch/x86/kvm/irq_comm.c         | 39 +++++++++--------------
 arch/x86/kvm/x86.c              | 36 +++++++++------------
 include/linux/kvm_host.h        |  4 +--
 virt/kvm/eventfd.c              |  4 +--
 virt/kvm/kvm_main.c             |  3 ++
 11 files changed, 85 insertions(+), 136 deletions(-)
Signature · 1 line
2.9.3