RFC pic/ioapic/irqchip cleanups + minor fixes
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest21 patches 5 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/21 | KVM: x86: race between KVM_SET_GSI_ROUTING and KVM_CREATE_IRQCHIPvirt/ | +3 | 0 replies | |
| 2/21 | KVM: x86: check against irqchip_mode in kvm_set_routing_entry()arch/ arch/ arch/ +1 more | +12 | 5 replies | |
| 3/21 | KVM: x86: check against irqchip_mode in pic_in_kernel()arch/ | +1 | 0 replies | |
| 4/21 | KVM: x86: check against irqchip_mode in ioapic_in_kernel()arch/ | +1 | 0 replies | |
| 5/21 | KVM: x86: get rid of pic_irqchip()arch/ arch/ arch/ +2 more | +16 | 0 replies | |
| 6/21 | KVM: x86: get rid of ioapic_irqchip()arch/ arch/ | +2 | 0 replies | |
| 7/21 | KVM: x86: use ioapic_in_kernel() to check for ioapic existencearch/ | +1 | 0 replies | |
| 8/21 | KVM: x86: remove duplicate checks for ioapicarch/ | +0 | 0 replies | |
| 9/21 | KVM: x86: convert kvm_(set|get)_ioapic() into voidarch/ arch/ arch/ | +6 | 0 replies | |
| 10/21 | KVM: x86: don't take kvm->irq_lock when creating IRQCHIParch/ | +0 | 0 replies | |
| 11/21 | KVM: x86: push usage of slots_lock downarch/ arch/ arch/ | +4 | 0 replies | |
| 12/21 | KVM: x86: KVM_IRQCHIP_PIC_MASTER only has 8 pinsarch/ | +6 | 0 replies | |
| 13/21 | KVM: x86: remove all-vcpu request from kvm_ioapic_init()arch/ | +0 | 0 replies | |
| 14/21 | KVM: x86: directly call kvm_make_scan_ioapic_request() in ioapic.carch/ | +2 | 0 replies | |
| 15/21 | KVM: x86: rename kvm_vcpu_request_scan_ioapic()arch/ include/ virt/ | +5 | 0 replies | |
| 16/21 | KVM: x86: drop goto label in kvm_set_routing_entry()arch/ | +7 | 0 replies | |
| 17/21 | KVM: x86: simplify pic_unlock()arch/ | +3 | 0 replies | |
| 18/21 | KVM: x86: make kvm_pic_reset() staticarch/ arch/ | +1 | 0 replies | |
| 19/21 | KVM: x86: drop picdev_in_range()arch/ | +12 | 0 replies | |
| 20/21 | KVM: x86: set data directly in picdev_read()arch/ | +3 | 0 replies | |
| 21/21 | KVM: x86: simplify pic_ioport_read()arch/ | +3 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH RFC 00/21] pic/ioapic/irqchip cleanups + minor fixes
My attempt to further cleanup pic/ioapic checks using irqchip_mode + other cleanups in that area.
The goal is to only check against irqchip_mode and not to rely on vpic/vioapic variables anymore to test for existence of pic/ioapic. This will avoid any possible races when creating the kernel irqchip fails.
Feel free to nack if a a certain cleanup is not worth it.
David Hildenbrand (21):
KVM: x86: race between KVM_SET_GSI_ROUTING and KVM_CREATE_IRQCHIP
KVM: x86: check against irqchip_mode in kvm_set_routing_entry()
KVM: x86: check against irqchip_mode in pic_in_kernel()
KVM: x86: check against irqchip_mode in ioapic_in_kernel()
KVM: x86: get rid of pic_irqchip()
KVM: x86: get rid of ioapic_irqchip()
KVM: x86: use ioapic_in_kernel() to check for ioapic existence
KVM: x86: remove duplicate checks for ioapic
KVM: x86: convert kvm_(set|get)_ioapic() into void
KVM: x86: don't take kvm->irq_lock when creating IRQCHIP
KVM: x86: push usage of slots_lock down
KVM: x86: KVM_IRQCHIP_PIC_MASTER only has 8 pins
KVM: x86: remove all-vcpu request from kvm_ioapic_init()
KVM: x86: directly call kvm_make_scan_ioapic_request() in ioapic.c
KVM: x86: rename kvm_vcpu_request_scan_ioapic()
KVM: x86: drop goto label in kvm_set_routing_entry()
KVM: x86: simplify pic_unlock()
KVM: x86: make kvm_pic_reset() static
KVM: x86: drop picdev_in_range()
KVM: x86: set data directly in picdev_read()
KVM: x86: simplify pic_ioport_read()
arch/x86/include/asm/kvm_host.h | 1 + arch/x86/kvm/i8259.c | 70 +++++++++++++++-------------------------- arch/x86/kvm/ioapic.c | 28 ++++++----------- arch/x86/kvm/ioapic.h | 14 ++------- arch/x86/kvm/irq.c | 2 +- arch/x86/kvm/irq.h | 20 +++++------- arch/x86/kvm/irq_comm.c | 39 +++++++++-------------- arch/x86/kvm/x86.c | 36 +++++++++------------ include/linux/kvm_host.h | 4 +-- virt/kvm/eventfd.c | 4 +-- virt/kvm/kvm_main.c | 3 ++ 11 files changed, 85 insertions(+), 136 deletions(-)
Signature · 1 line
2.9.3