Skip to content

net: bcmgenet: minor bug fixes

Doug Berger lkml netdev 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest8 patches 10 repliesIn review
  2. v18 patches 0 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8net: bcmgenet: correct the RBUF_OVFL_CNT and RBUF_ERR_CNT MIB valuesdrivers/net/ethernet/broadcom/genet/bcmgenet.c drivers/net/ethernet/broadcom/genet/bcmgenet.h+60 -101 reply
2/8net: bcmgenet: correct MIB access of UniMAC RUNT countersdrivers/net/ethernet/broadcom/genet/bcmgenet.c+7 -41 reply
3/8net: bcmgenet: reserved phy revisions must be checked firstdrivers/net/ethernet/broadcom/genet/bcmgenet.c+6 -61 reply
4/8net: bcmgenet: power down internal phy if open or resume failsdrivers/net/ethernet/broadcom/genet/bcmgenet.c+4 -01 reply
5/8net: bcmgenet: synchronize irq0 status between the isr and taskdrivers/net/ethernet/broadcom/genet/bcmgenet.c drivers/net/ethernet/broadcom/genet/bcmgenet.h+44 -351 reply
6/8net: bcmgenet: Power up the internal PHY before probing the MIIdrivers/net/ethernet/broadcom/genet/bcmgenet.c+8 -01 reply
7/8net: bcmgenet: add begin/complete ethtool opsdrivers/net/ethernet/broadcom/genet/bcmgenet.c+18 -01 reply
8/8net: bcmgenet: decouple flow control from bcmgenet_tx_reclaimdrivers/net/ethernet/broadcom/genet/bcmgenet.c+11 -91 reply

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchFlorian Fainelli
1/8R-b
2/8R-b
3/8R-b
4/8R-b
5/8R-b
6/8R-b
7/8R-b
8/8R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 net 0/8] net: bcmgenet: minor bug fixes

v2: Accidentally sent the wrong set after rebasing.

This collection contains a number of fixes for minor issues with the bcmgenet driver most of which were present in the initial submission of the driver.

Some bugs were uncovered by inspection prior to the upcoming update for GENETv5 support:
net: bcmgenet: correct the RBUF_OVFL_CNT and RBUF_ERR_CNT MIB values
net: bcmgenet: correct MIB access of UniMAC RUNT counters
net: bcmgenet: reserved phy revisions must be checked first
net: bcmgenet: synchronize irq0 status between the isr and task

Others bugs were found in power management testing:
net: bcmgenet: power down internal phy if open or resume fails
net: bcmgenet: Power up the internal PHY before probing the MII
net: bcmgenet: decouple flow control from bcmgenet_tx_reclaim
net: bcmgenet: add begin/complete ethtool ops

Doug Berger (7):
net: bcmgenet: correct the RBUF_OVFL_CNT and RBUF_ERR_CNT MIB values
net: bcmgenet: correct MIB access of UniMAC RUNT counters
net: bcmgenet: reserved phy revisions must be checked first
net: bcmgenet: power down internal phy if open or resume fails
net: bcmgenet: synchronize irq0 status between the isr and task
net: bcmgenet: Power up the internal PHY before probing the MII
net: bcmgenet: decouple flow control from bcmgenet_tx_reclaim

Edwin Chan (1):
net: bcmgenet: add begin/complete ethtool ops

 drivers/net/ethernet/broadcom/genet/bcmgenet.c | 206 ++++++++++++++++++-------
 drivers/net/ethernet/broadcom/genet/bcmgenet.h |  16 +-
 2 files changed, 158 insertions(+), 64 deletions(-)
Signature · 1 line
2.11.1