Skip to content

staging: speakup: introduce tty-based comms

[email protected] linux-serial lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 16 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7tty_port: allow a port to be opened with a tty that has no file handledrivers/tty/tty_io.c drivers/tty/tty_port.c include/linux/tty.h+12 -63 replies
2/7staging: speakup: spk_serial_out and spk_wait_for_xmitr to take synth argdrivers/staging/speakup/serialio.c drivers/staging/speakup/speakup_apollo.c drivers/staging/speakup/speakup_audptr.c +4 more+29 -290 replies
3/7staging: serial: add spk_io_ops struct to spk_synthdrivers/staging/speakup/serialio.c drivers/staging/speakup/speakup_acntpc.c drivers/staging/speakup/speakup_acntsa.c +16 more+48 -200 replies
4/7staging: speakup: move spk_stop_serial_interrupt into synth-specific release functiondrivers/staging/speakup/serialio.c drivers/staging/speakup/speakup_acntpc.c drivers/staging/speakup/speakup_decpc.c +3 more+6 -10 replies
5/7staging: speakup: move those functions which do outgoing serial comms, into serialio.cdrivers/staging/speakup/serialio.c drivers/staging/speakup/speakup_acntsa.c drivers/staging/speakup/speakup_apollo.c +10 more+61 -610 replies
6/7staging: speakup: add tty-based comms functionsdrivers/staging/speakup/Makefile drivers/staging/speakup/spk_priv.h drivers/staging/speakup/spk_ttyio.c +2 more+151 -00 replies
7/7staging: speakup: migrate acntsa, bns, dummy and txprt to ttyiodrivers/staging/speakup/speakup_acntsa.c drivers/staging/speakup/speakup_dummy.c drivers/staging/speakup/speakup_txprt.c+12 -120 replies

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchSamuel Thibault
1/7R-b
2/7R-b
3/7R-b
4/7R-b
5/7R-b
6/7R-b
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [patch 0/7] staging: speakup: introduce tty-based comms

Hi,

This patchset introduces a TTY-based way for the synths to communicate with devices as an alternate for direct serial comms used by the synths at the moment. It then migrates some of the synths to the TTY-based comms. Synths migrated in this patchset are dummy, acntsa, bns and txprt.

As such, this series is meant to start a discussion on the changes in the first patch: "tty_port: allow a port to be opened with a tty that has no file handle". This allows speakup to access tty port early on during boot, making it possible to start emiting messages as early as possible. This is demonstrated in patch 6, where it calls tty_open_by_driver, passing in NULL for inode and filp params.

To wrap up, here is a summary of the patches that follow. Patch 1 enables kernel access to TTY device. Patches 2 - 5 prepare the code to accomodate TTY-based comms as an alternate to raw serial I/O for outputting data to external device. Patch 6 builds upon the changes made in patch 1 and utilises TTY-subsystem to communicate with external device - currently just over ttyS* but with plans to expand it to other TTY devices soon. Finally, patch 7 does actual migration of some of the simple synths from raw serial comms to TTY.

Okash