Skip to content

fix ext4 support for volumes greater than 4 GiB

Antony Pavlov barebox 1 version Applied

Status from this message: Applied all, thanks

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 1 replyApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/7ext4: change structure fields to __le/__be typesfs/ext4/ext_common.h+68 -680 replies
2/7ext4: use kernel names for byte swapsfs/ext4/ext4_common.c fs/ext4/ext4fs.c fs/ext4/ext_barebox.c +1 more+39 -390 replies
3/7ext4: drop unused and misdefined INODE_SIZE_FILESYSTEM macrofs/ext4/ext_common.h+0 -20 replies
4/7ext4: fix wrong usage of le32_to_cpu()fs/ext4/ext4_common.c+1 -10 replies
5/7ext4: Update ext2/3/4 superblock, group descriptor and inode structuresfs/ext4/ext_common.h+46 -40 replies
6/7ext4: determine group descriptor size for 64bit featurefs/ext4/ext4_common.c fs/ext4/ext4fs.h+19 -50 replies
7/7ext4: Use correct descriptor size when reading the block group descriptorfs/ext4/ext4_common.c+4 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/7] fix ext4 support for volumes greater than 4 GiB

At the moment barebox can't correctly handle ext4 filesystem volume greater than 4 GiB.

This patchseries fixes the problem by adaption of U-Boot commits.

How to reproduce the problem:

    $ git clone https://git.pengutronix.de/git/barebox
    $ cd barebox
    barebox$ dd if=/dev/zero bs=128M count=40 of=5G.img
    barebox$ /sbin/mkfs.ext4 -F 5G.img
    barebox$ mkdir mnt
    barebox$ sudo mount 5G.img mnt/
    barebox$ sudo mkdir mnt/testdir
    barebox$ sudo touch mnt/testdir/testfile
    barebox$ ls mnt/testdir/testfile -l
    -rw-r--r-- 1 root root 0 Mar 20 14:53 mnt/testdir/testfile
    barebox$ sudo umount mnt/
    barebox$ make sandbox_defconfig
    ...
    barebox$ make -j3 -s
    ...
    barebox$ ./barebox -i 5G.img
    ...
    barebox@barebox sandbox:/ mount /dev/fd0 /mnt/
    ext4 ext40: EXT2 rev 1, inode_size 256
    barebox@barebox sandbox:/ ls /mnt/testdir/testfile
    ls: /mnt/testdir/testfile: No such file or directory
    barebox@barebox sandbox:/ ls /mnt/ -l
    drwxrwxrwx              0 .
    drwxrwxrwx              0 ..
    drwx------          16384 lost+found
    ?---------              0 testdir

On the other hand there is no problem with volumes less than 4 GiB:

barebox$ dd if=/dev/zero bs=128M count=24 of=3G.img barebox$ /sbin/mkfs.ext4 -F 3G.img
barebox$ sudo mount 3G.img mnt/
barebox$ sudo mkdir mnt/testdir
barebox$ sudo touch mnt/testdir/testfile barebox$ ls mnt/testdir/testfile -l
-rw-r--r-- 1 root root 0 Mar 20 15:05 mnt/testdir/testfile barebox$ sudo umount mnt/
barebox$ ./barebox -i 3G.img
...
barebox@barebox sandbox:/ mount /dev/fd0 /mnt/ ext4 ext40: EXT2 rev 1, inode_size 256 barebox@barebox sandbox:/ ls /mnt/testdir/testfile /mnt/testdir/testfile
barebox@barebox sandbox:/ ls /mnt/ -l
drwxrwxrwx 0 .
drwxrwxrwx 0 ..
drwx------ 16384 lost+found
drwxr-xr-x 4096 testdir

Antony Pavlov (7):
ext4: change structure fields to __le/__be types
ext4: use kernel names for byte swaps
ext4: drop unused and misdefined INODE_SIZE_FILESYSTEM macro
ext4: fix wrong usage of le32_to_cpu()
ext4: Update ext2/3/4 superblock, group descriptor and inode
structures
ext4: determine group descriptor size for 64bit feature
ext4: Use correct descriptor size when reading the block group
descriptor

 fs/ext4/ext4_common.c |  83 +++++++++++++----------
 fs/ext4/ext4fs.c      |   2 +-
 fs/ext4/ext4fs.h      |   3 +
 fs/ext4/ext_barebox.c |  10 +--
 fs/ext4/ext_common.h  | 184 ++++++++++++++++++++++++++++++--------------------
 5 files changed, 168 insertions(+), 114 deletions(-)
Signature · 7 lines
2.11.0


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox