Skip to content

t1400: modernize style

Kyle Meyer git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 10 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5t1400: rename test descriptions to be uniquet/t1400-update-ref.sh+4 -41 reply
2/5t1400: set core.logAllRefUpdates in "logged by touch" testst/t1400-update-ref.sh+12 -112 replies
3/5t1400: use test_path_is_* helperst/t1400-update-ref.sh+22 -221 reply
4/5t1400: remove a set of unused output filest/t1400-update-ref.sh+2 -21 reply
5/5t1400: use test_when_finished for cleanupt/t1400-update-ref.sh+41 -401 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] t1400: modernize style

These patches follow up on Peff's suggestion to modernize the style in t1400-update-ref.sh.

    [email protected]

The first two commits aren't concerned with "modernizing" the tests, but instead address issues that I noticed while looking more closely at t1400.

I also considered

* making the quoting/spacing/breaks around the test descriptions and bodies more consistent, but I think this leads to too much code churn.

* moving the here-documents for log creation into the following tests, but I don't think it's worth it because it makes already long lines even longer.

t1400: rename test descriptions to be unique
t1400: set core.logAllRefUpdates in "logged by touch" tests
t1400: use test_path_is_* helpers
t1400: remove a set of unused output files
t1400: use test_when_finished for cleanup

 t/t1400-update-ref.sh | 154 +++++++++++++++++++++++++-------------------------
 1 file changed, 78 insertions(+), 76 deletions(-)
Signature · 1 line
2.12.0