short status: improve reporting for submodule changes
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest8 patches 1 replyIn review
v4 from the cover letter
* broken down in a lot of tiny patches.
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | submodule.c: port is_submodule_modified to use porcelain 2submodule.c | +24 | 0 replies | |
| 2/8 | submodule.c: use argv_array in is_submodule_modifiedsubmodule.c | +21 | 0 replies | |
| 3/8 | submodule.c: convert is_submodule_modified to use strbuf_getwholeline_fdsubmodule.c | +2 | 0 replies | |
| 4/8 | submodule.c: port is_submodule_modified to use porcelain 2submodule.c | +4 | 0 replies | |
| 5/8 | submodule.c: factor out early loop termination in is_submodule_modifiedsubmodule.c | +6 | 0 replies | |
| 6/8 | submodule.c: stricter checking for submodules in is_submodule_modifiedsubmodule.c | +3 | 0 replies | |
| 7/8 | short status: improve reporting for submodule changesDocumentation/ t/ t/ +1 more | +90 | 0 replies | |
| 8/8 | submodule.c: correctly handle nested submodules in is_submodule_modifiedsubmodule.c t/ t/ | +16 | 0 replies |
Reviews trailers per patch
1 of 8 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Jonathan Nieder |
|---|---|
| Series | R-b Helped-by R-b Helped-by R-b Helped-by R-b R-b R-b R-b R-b R-b Helped-by R-b Helped-by R-b R-b R-b Helped-by R-b Helped-by R-b R-b |
| 1/8 | |
| 2/8 | |
| 3/8 | |
| 4/8 | |
| 5/8 | |
| 6/8 | R-b |
| 7/8 | Helped-by |
| 8/8 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/8] short status: improve reporting for submodule changes
v4:
* broken down in a lot of tiny patches.
Quoted 4 lines · Jonathan
Patch 1/3 is the one that gives me pause, since I hadn't been able to chase down all callers. Would it be feasible to split that into two:
one patch to switch to --porcelain=2 but not change behavior, and a separate patch to improve what is stored in thedirty_submoduleflags?
This part is in the latest patch now.
Thanks,
Stefan
v3:
This comes as a series; first I'd like to refactor is_submodule_modified to take advantage of the new porcelain=2 plumbing switch to check for changes in the submodule.
On top of the refactoring comes the actual change, which moved the rewriting of the submodule change indicator letter to the collection part.
Thanks,
Stefan
Stefan Beller (8):
submodule.c: port is_submodule_modified to use porcelain 2 submodule.c: use argv_array in is_submodule_modified submodule.c: convert is_submodule_modified to use
strbuf_getwholeline_fd
submodule.c: port is_submodule_modified to use porcelain 2 submodule.c: factor out early loop termination in
is_submodule_modified
submodule.c: stricter checking for submodules in is_submodule_modified short status: improve reporting for submodule changes submodule.c: correctly handle nested submodules in
is_submodule_modified
Documentation/git-status.txt | 9 +++++++ submodule.c | 56 ++++++++++++++++++++----------------------- t/t3600-rm.sh | 18 ++++++++++---- t/t7506-status-submodule.sh | 57 ++++++++++++++++++++++++++++++++++++++++++++ wt-status.c | 13 ++++++++-- 5 files changed, 116 insertions(+), 37 deletions(-)
Signature · 1 line
2.12.1.438.gb674c4c09c