bq27xxx_battery partial series
Get series with b4
b4 am [email protected]Versions newest first
- v12 Latest0 of 5 patches 0 repliesNew
Patches in v12 No applies recorded yet
None of the 5 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v12 yet.
Cover letter [PATCH v12 0/5] bq27xxx_battery partial series
Andrew, here are the bq27xxx related patches, revised and refactored from your feedback. I refactored with a somewhat diff mix than you suggested for the sake of readability.
Changes prior to refactoring:
https://github.com/networkimprov/linux/commit/a9c984f0
https://github.com/networkimprov/linux/commit/59fb17ac
I didn't take these 5 suggestions:
/* BlockDataControl() -> Block Data Control, etc
I prefer terms from the docs so that searches in docs for the comment string work.
/* Reports EINVAL ...
This is obvious from the code.
Error reporting
You and Sebastian differ, so I dropped the patch, leaving dev_dbg in I/O methods. Pls resolve in a future patchset.
checksum_dm_block()
That code came from bqtool, which I don't want to second guess.
/* This sequence is toxic
It's essential to document a specific feature which must not be added to the code. I revised the comment.