Skip to content

NFC: fix device allocation and nfcmrvl crashes

Johan Hovold linux-wireless lkml netdev stable 2 versions – Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest8 patches 6 repliesApplied
  2. v17 patches 1 replySuperseded

Changes in v2 from the cover letter

- fix typo in commit message (1/8)
- release reset gpio in error paths (3/8)
- fix description of patch impact (3/8)
- allow gpio 0 to be used for reset signalling (8/8, new)

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/8NFC: fix broken device allocationnet/nfc/core.c net/nfc/nci/core.c+19 -150 replies
2/8NFC: nfcmrvl_uart: add missing tty-device sanity checkdrivers/nfc/nfcmrvl/uart.c+4 -40 replies
3/8NFC: nfcmrvl: do not use device-managed resourcesdrivers/nfc/nfcmrvl/main.c+11 -80 replies
4/8NFC: nfcmrvl: use nfc-device for firmware downloaddrivers/nfc/nfcmrvl/fw_dnld.c+5 -20 replies
5/8NFC: nfcmrvl: fix firmware-management initialisationdrivers/nfc/nfcmrvl/main.c+9 -70 replies
6/8NFC: nfcmrvl_uart: fix device-node leak during probedrivers/nfc/nfcmrvl/uart.c+3 -00 replies
7/8NFC: nfcmrvl_usb: use interface as phy devicedrivers/nfc/nfcmrvl/usb.c+1 -30 replies
8/8NFC: nfcmrvl: allow gpio 0 for reset signallingdrivers/nfc/nfcmrvl/main.c include/linux/platform_data/nfcmrvl.h+5 -60 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/8] NFC: fix device allocation and nfcmrvl crashes

This started out with the observation that the nfcmrvl_uart driver unconditionally dereferenced the tty class device despite the fact that not every tty has an associated struct device (Unix98 ptys). Some further changes were needed in the common nfcmrvl code to fully address this, some of which also incidentally fixed a few related bugs (e.g. resource leaks in error paths).

While fixing this I stumbled over a regression in NFC core that lead to broken registration error paths and misnamed workqueues.

Note that this has only been tested by configuring the n_hci line discipline for different ttys without any actual NFC hardware connected.

Johan

Changes in v2
- fix typo in commit message (1/8)
- release reset gpio in error paths (3/8)
- fix description of patch impact (3/8)
- allow gpio 0 to be used for reset signalling (8/8, new)

Johan Hovold (8):
NFC: fix broken device allocation
NFC: nfcmrvl_uart: add missing tty-device sanity check
NFC: nfcmrvl: do not use device-managed resources
NFC: nfcmrvl: use nfc-device for firmware download
NFC: nfcmrvl: fix firmware-management initialisation
NFC: nfcmrvl_uart: fix device-node leak during probe
NFC: nfcmrvl_usb: use interface as phy device
NFC: nfcmrvl: allow gpio 0 for reset signalling

 drivers/nfc/nfcmrvl/fw_dnld.c         |  7 ++++--
 drivers/nfc/nfcmrvl/main.c            | 40 +++++++++++++++++++----------------
 drivers/nfc/nfcmrvl/uart.c            | 11 ++++++----
 drivers/nfc/nfcmrvl/usb.c             |  4 +---
 include/linux/platform_data/nfcmrvl.h |  2 +-
 net/nfc/core.c                        | 31 +++++++++++++++------------
 net/nfc/nci/core.c                    |  3 +--
 7 files changed, 55 insertions(+), 43 deletions(-)
Signature · 1 line
2.12.2