Skip to content

bq27xxx_battery partial series

Liam Breck linux-pm 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 5 patches 2 repliesIn review

Patches in v1 No applies recorded yet

None of the 5 patches the cover letter announces are in this archive.

Reviews trailers per patch

PatchAndrew F. Davis
SeriesA-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH v12.2 0/5] bq27xxx_battery partial series

Changes in this rev:

Removed macro for if (...) dev_dbg(...) from I/O helper functions.

Moved update_dm_block() to patch "Add power_supply_battery_info support". No more refactoring please; it's not really improving the code itself :-)

set_cfgupdate is required for DM write on certain chips, see this Q&A
https://e2e.ti.com/support/power_management/battery_management/f/180/p/577798/2121489#2121489

Renamed dm_buf .full => .has_data, .updt => .dirty
dm_buf has 3 states: !has_data, has_data && !dirty, has_data && dirty I considered a single field and enum values, but I think this is clearer.

Renamed set_cfgupdate(..., u16 flag => state)
We call set_cfgupdate(di, BQ27XXX_FLAG_CFGUP or 0) We !!state to print the intended flag state in error msg.

power: bq27xxx_battery: Add bulk transfer bus methods
power: bq27xxx_battery: Add chip data memory read/write support
power: bq27xxx_battery: Add power_supply_battery_info support
power: bq27xxx_battery: Enable chip data memory update for certain chips
power: bq27xxx_battery: Remove duplicate register arrays

 drivers/power/supply/bq27xxx_battery.c     | 700 +++++++++++++++++++++++------
 drivers/power/supply/bq27xxx_battery_i2c.c |  98 +++-
 include/linux/power/bq27xxx_battery.h      |  26 +-
 3 files changed, 682 insertions(+), 142 deletions(-)
Signature · 1 line
2.9.3