Skip to content

ftgmac100: Rework batch 1 - Link & Interrupts

Benjamin Herrenschmidt netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest13 patches 9 repliesIn review
  2. v113 patches 9 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13ftgmac100: Use netdev->irq instead of private copydrivers/net/ethernet/faraday/ftgmac100.c+6 -70 replies
2/13ftgmac100: Remove "banner" commentsdrivers/net/ethernet/faraday/ftgmac100.c+0 -420 replies
3/13ftgmac100: Reorder struct fields and commentdrivers/net/ethernet/faraday/ftgmac100.c+12 -70 replies
4/13ftgmac100: Remove "enabled" flagsdrivers/net/ethernet/faraday/ftgmac100.c+0 -70 replies
5/13ftgmac100: Cleanup speed/duplex tracking and fix duplex configdrivers/net/ethernet/faraday/ftgmac100.c+44 -81 reply
6/13ftgmac100: Split ring alloc, init and rx buffer allocdrivers/net/ethernet/faraday/ftgmac100.c+47 -210 replies
7/13ftgmac100: Move napi_add/del to open/closedrivers/net/ethernet/faraday/ftgmac100.c+5 -30 replies
8/13ftgmac100: Request the interrupt only after HW is resetdrivers/net/ethernet/faraday/ftgmac100.c+10 -90 replies
9/13ftgmac100: Move the bulk of inits to a separate functiondrivers/net/ethernet/faraday/ftgmac100.c+42 -290 replies
10/13ftgmac100: Add a reset task and use it for link changesdrivers/net/ethernet/faraday/ftgmac100.c+74 -131 reply
11/13ftgmac100: Rework MAC reset and initdrivers/net/ethernet/faraday/ftgmac100.c+59 -390 replies
12/13ftgmac100: Remove useless tests in interrupt handlerdrivers/net/ethernet/faraday/ftgmac100.c+3 -80 replies
13/13ftgmac100: Rework NAPI & interrupts handlingdrivers/net/ethernet/faraday/ftgmac100.c drivers/net/ethernet/faraday/ftgmac100.h+90 -610 replies

Reviews trailers per patch

2 of 13 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchFlorian FainelliAndrew Lunn
SeriesR-b
1/13
2/13
3/13
4/13
5/13R-b
6/13
7/13
8/13
9/13
10/13R-b
11/13
12/13
13/13

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/13] ftgmac100: Rework batch 1 - Link & Interrupts

This is version 2 of the first batch of updates to the ftgmac100 driver.

Essentially:

- A few misc cleanups
- Fixing link speed & duplex handling (including dealing with an Aspeed requirement to double reset the controller when the speed changes)
- And addition of a reset task workqueue which will be used for delaying the re-initialization of the controller
- Fixing a number of issues with how interrupts and NAPI are dealt with.

Subsequent batches will rework and improve the rx path, the tx path, and add a bunch of features and fixes.

Version 2 addresses some review comments to patches 5 and 10 (see version history in the respective emails).