forking and threading
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest11 patches 15 repliesIn review
- v511 patches 14 repliesSuperseded
- v410 patches 2 repliesSuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 | 10 patches | 6 replies | Superseded | |
| v2 | 6 patches | 15 replies | Superseded | |
| v1 | 5 patches | 15 replies | Superseded |
Changes in v6 from the cover letter
* fix some windows compat issues
* better comment on the string_list_remove function (also marked extern)
Patches in v6 No applies recorded yet
Reviews trailers per patch
None of the 11 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Eric Wong | Jonathan Nieder |
|---|---|---|
| Series | R-b R-b R-b R-b | |
| 1/11 | ||
| 2/11 | ||
| 3/11 | ||
| 4/11 | ||
| 5/11 | ||
| 6/11 | ||
| 7/11 | ||
| 8/11 | Helped-by | |
| 9/11 | ||
| 10/11 | ||
| 11/11 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v6 00/11] forking and threading
Changes in v6:
* fix some windows compat issues
* better comment on the string_list_remove function (also marked extern)
Brandon Williams (10):
t5550: use write_script to generate post-update hook
t0061: run_command executes scripts without a #! line
run-command: prepare command before forking
run-command: use the async-signal-safe execv instead of execvp
string-list: add string_list_remove function
run-command: prepare child environment before forking
run-command: don't die in child when duping /dev/null
run-command: eliminate calls to error handling functions in child
run-command: handle dup2 and close errors in child
run-command: add note about forking and threading
Eric Wong (1):
run-command: block signals between fork and execve
run-command.c | 404 +++++++++++++++++++++++++++++++++++---------- string-list.c | 18 ++ string-list.h | 7 + t/t0061-run-command.sh | 11 ++ t/t5550-http-fetch-dumb.sh | 5 +- 5 files changed, 360 insertions(+), 85 deletions(-)
--- interdiff with 'origin/bw/forking-and-threading'
run-command.c +1 -1
@@ -402,7 +402,6 @@ static char **prep_childenv(const char *const *deltaenv)strbuf_release (&key);return childenv; } -#endif struct atfork_state {#ifndef NO_PTHREADS
@@ -450,6 +449,7 @@ static void atfork_parent(struct atfork_state *as) "restoring signal mask"); #endif } +#endif /* GIT_WINDOWS_NATIVE */ static inline void set_cloexec (int fd) {
string-list.h +3 -1
@@ -64,8 +64,10 @@ struct string_list_item *string_list_insert(struct string_list *list, const char/* * Removes the given string from the sorted list. +* If the string doesn't exist, the list is not altered. */ -void string_list_remove (struct string_list *list,const char *string,int free_util); +extern void string_list_remove (struct string_list *list,const char *string, +int free_util);/* * Checks if the given string is part of a sorted list. If it is part of the list,
t/t0061-run-command.sh +1 -1
@@ -26,7 +26,7 @@ test_expect_success 'run_command can run a command' ' test_cmp empty err ' -test_expect_success 'run_command can run a script without a #! line' ' +test_expect_success !MINGW 'run_command can run a script without a #! line' ' cat >hello <<-\EOF && cat hello-script EOF
Signature · 1 line
2.12.2.816.g2cccc81164-goog