Skip to content

serdev: fix broken lifetime assumptions

Johan Hovold linux-serial lkml 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 0 repliesNew
  2. v14 patches 8 repliesSuperseded

Changes in v2 from the cover letter

- rebase on tty-linus
- drop first two patches that have already been applied
- remove a stray newline in patch 1/2
- add Rob's reviewed-by tag

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2tty/serdev: add serdev registration interfacedrivers/tty/serdev/serdev-ttyport.c drivers/tty/tty_port.c include/linux/serdev.h +1 more+93 -40 replies
2/2serial: enable serdev supportdrivers/tty/serial/serial_core.c+2 -20 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchRob Herring
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] serdev: fix broken lifetime assumptions

This series fixes a number of issues with the new serdev code, which was based on incorrect tty-port lifetime assumptions.

The first patch in v1 of this series disables serdev support by reverting the patch which hooked into the tty layer in a broken way that leads to crashes and leaks when deregistering devices. That one has now been applied to tty-linus with a stable tag (for v4.11).

The remaining two patches again re-enables serdev (first enabled in 4.11, but soon reverted in stable) for a subset of tty drivers by adding adding a new interface for registering serdev devices and using that in serial core only.

More details can be found in the individual commit messages.

Johan

Changes in v2
- rebase on tty-linus
- drop first two patches that have already been applied
- remove a stray newline in patch 1/2
- add Rob's reviewed-by tag

Johan Hovold (2):
tty/serdev: add serdev registration interface
serial: enable serdev support

 drivers/tty/serdev/serdev-ttyport.c |  6 ++-
 drivers/tty/serial/serial_core.c    |  4 +-
 drivers/tty/tty_port.c              | 75 +++++++++++++++++++++++++++++++++++++
 include/linux/serdev.h              |  7 +++-
 include/linux/tty.h                 |  9 +++++
 5 files changed, 95 insertions(+), 6 deletions(-)
Signature · 1 line
2.13.0