make dirty-bitmap byte-based
Status from this message: Thanks, applied to the block branch.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v10 Latest20 patches 10 repliesApplied
- v920 patches 7 repliesSuperseded
- v820 patches 6 repliesSuperseded
Earlier versions · 7
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v7 | 20 patches | 8 replies | Superseded | |
| v6 | 18 patches | 11 replies | Superseded | |
| v5 | 18 patches | 8 replies | Superseded | |
| v4 | 17 patches | 20 replies | Superseded | |
| v3 | 11 patches | 3 replies | Superseded | |
| v2 | 12 patches | 5 replies | Superseded | |
| v1 | 12 patches | 19 replies | Superseded |
Changes in v10 from the cover letter
- another try at patch 5 [John]
- add R-b where appropriate
Patches in v10 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/20 | block: Make bdrv_img_create() size selection easier to readblock.c | +1 | 0 replies | |
| 2/20 | hbitmap: Rename serialization_granularity to serialization_alignblock/ include/ tests/ +1 more | +14 | 0 replies | |
| 3/20 | qcow2: Ensure bitmap serialization is alignedblock/ | +5 | 0 replies | |
| 4/20 | dirty-bitmap: Drop unused functionsblock/ include/ | +0 | 0 replies | |
| 5/20 | dirty-bitmap: Avoid size query failure during truncateblock.c block/ include/ | +15 | 5 replies | |
| 6/20 | dirty-bitmap: Change bdrv_dirty_bitmap_size() to report bytesblock/ block/ | +9 | 0 replies | |
| 7/20 | dirty-bitmap: Track bitmap size by bytesblock/ | +14 | 0 replies | |
| 8/20 | dirty-bitmap: Change bdrv_dirty_bitmap_*serialize*() to take bytesblock/ block/ include/ | +45 | 0 replies | |
| 9/20 | qcow2: Switch sectors_covered_by_bitmap_cluster() to byte-basedblock/ | +14 | 0 replies | |
| 10/20 | dirty-bitmap: Set iterator start by offset, not sectorblock/ block/ block/ +2 more | +12 | 0 replies | |
| 11/20 | dirty-bitmap: Change bdrv_dirty_iter_next() to report byte offsetblock/ block/ block/ +1 more | +8 | 0 replies | |
| 12/20 | dirty-bitmap: Change bdrv_get_dirty_count() to report bytesblock/ block/ migration/ | +9 | 0 replies | |
| 13/20 | dirty-bitmap: Change bdrv_get_dirty_locked() to take bytesblock/ block/ include/ +1 more | +9 | 0 replies | |
| 14/20 | dirty-bitmap: Change bdrv_[re]set_dirty_bitmap() to use bytesblock/ block/ include/ +1 more | +31 | 0 replies | |
| 15/20 | mirror: Switch mirror_dirty_init() to byte-based iterationblock/ | +14 | 0 replies | |
| 16/20 | qcow2: Switch qcow2_measure() to byte-based iterationblock/ | +10 | 0 replies | |
| 17/20 | qcow2: Switch load_bitmap_data() to byte-based iterationblock/ | +8 | 0 replies | |
| 18/20 | qcow2: Switch store_bitmap_data() to byte-based iterationblock/ tests/ | +17 | 3 replies | |
| 19/20 | dirty-bitmap: Switch bdrv_set_dirty() to bytesblock/ block/ include/ | +7 | 0 replies | |
| 20/20 | dirty-bitmap: Convert internal hbitmap size/granularityblock/ | +18 | 0 replies |
Reviews trailers per patch
All 20 patches have a Reviewed-by or Acked-by.
| Patch | John Snow | Kevin Wolf | Fam Zheng | Juan Quintela | Vladimir Sementsov-Ogievskiy |
|---|---|---|---|---|---|
| Series | T-b | ||||
| 1/20 | R-b | R-b | R-b | ||
| 2/20 | R-b | R-b | R-b | ||
| 3/20 | R-b | R-b | R-b | ||
| 4/20 | R-b | R-b | R-b | ||
| 5/20 | R-b | R-b | R-b | ||
| 6/20 | R-b | R-b | R-b | ||
| 7/20 | R-b | R-b | R-b | ||
| 8/20 | R-b | R-b | R-b | ||
| 9/20 | R-b | R-b | R-b | ||
| 10/20 | R-b | R-b | R-b | ||
| 11/20 | R-b | R-b | R-b | ||
| 12/20 | R-b | R-b | R-b | ||
| 13/20 | R-b | R-b | R-b | R-b | |
| 14/20 | R-b | R-b | R-b | ||
| 15/20 | R-b | R-b | R-b | ||
| 16/20 | R-b | R-b | R-b | ||
| 17/20 | R-b | R-b | R-b | R-b | |
| 18/20 | R-b | R-b | R-b | ||
| 19/20 | R-b | R-b | R-b | ||
| 20/20 | R-b | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.
Cover letter [Qemu-devel] [PATCH v10 00/20] make dirty-bitmap byte-based
There are patches floating around to add NBD_CMD_BLOCK_STATUS, but NBD wants to report status on byte granularity (even if the reporting will probably be naturally aligned to sectors or even much higher levels). I've therefore started the task of converting our block status code to report at a byte granularity rather than sectors.
Now that 2.11 is open, I'm rebasing/reposting the remaining patches.
The overall conversion currently looks like:
part 1: bdrv_is_allocated (merged in 2.10, commit 51b0a488) part 2: dirty-bitmap (this series, v9 was here [1])
part 3: bdrv_get_block_status (v4 is posted [2] and is mostly reviewed) part 4: .bdrv_co_block_status (v3 is posted [3], but needs review)
Available as a tag at:
git fetch git://repo.or.cz/qemu/ericb.git nbd-byte-dirty-v10
[1] https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg05387.html
[2] https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg03543.html
[3] https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg03812.html
Since v9:
- another try at patch 5 [John]
- add R-b where appropriate
001/20:[----] [--] 'block: Make bdrv_img_create() size selection easier to read' 002/20:[----] [--] 'hbitmap: Rename serialization_granularity to serialization_align' 003/20:[----] [--] 'qcow2: Ensure bitmap serialization is aligned' 004/20:[----] [--] 'dirty-bitmap: Drop unused functions'
005/20:[0003] [FC] 'dirty-bitmap: Avoid size query failure during truncate' 006/20:[----] [--] 'dirty-bitmap: Change bdrv_dirty_bitmap_size() to report bytes' 007/20:[----] [--] 'dirty-bitmap: Track bitmap size by bytes' 008/20:[----] [--] 'dirty-bitmap: Change bdrv_dirty_bitmap_*serialize*() to take bytes' 009/20:[----] [--] 'qcow2: Switch sectors_covered_by_bitmap_cluster() to byte-based' 010/20:[----] [--] 'dirty-bitmap: Set iterator start by offset, not sector' 011/20:[----] [--] 'dirty-bitmap: Change bdrv_dirty_iter_next() to report byte offset' 012/20:[----] [--] 'dirty-bitmap: Change bdrv_get_dirty_count() to report bytes' 013/20:[----] [--] 'dirty-bitmap: Change bdrv_get_dirty_locked() to take bytes' 014/20:[----] [--] 'dirty-bitmap: Change bdrv_[re]set_dirty_bitmap() to use bytes' 015/20:[----] [--] 'mirror: Switch mirror_dirty_init() to byte-based iteration' 016/20:[----] [--] 'qcow2: Switch qcow2_measure() to byte-based iteration' 017/20:[----] [--] 'qcow2: Switch load_bitmap_data() to byte-based iteration' 018/20:[----] [--] 'qcow2: Switch store_bitmap_data() to byte-based iteration' 019/20:[----] [--] 'dirty-bitmap: Switch bdrv_set_dirty() to bytes' 020/20:[----] [--] 'dirty-bitmap: Convert internal hbitmap size/granularity'
Eric Blake (20):
block: Make bdrv_img_create() size selection easier to read
hbitmap: Rename serialization_granularity to serialization_align
qcow2: Ensure bitmap serialization is aligned
dirty-bitmap: Drop unused functions
dirty-bitmap: Avoid size query failure during truncate
dirty-bitmap: Change bdrv_dirty_bitmap_size() to report bytes
dirty-bitmap: Track bitmap size by bytes
dirty-bitmap: Change bdrv_dirty_bitmap_*serialize*() to take bytes
qcow2: Switch sectors_covered_by_bitmap_cluster() to byte-based
dirty-bitmap: Set iterator start by offset, not sector
dirty-bitmap: Change bdrv_dirty_iter_next() to report byte offset
dirty-bitmap: Change bdrv_get_dirty_count() to report bytes
dirty-bitmap: Change bdrv_get_dirty_locked() to take bytes
dirty-bitmap: Change bdrv_[re]set_dirty_bitmap() to use bytes
mirror: Switch mirror_dirty_init() to byte-based iteration
qcow2: Switch qcow2_measure() to byte-based iteration
qcow2: Switch load_bitmap_data() to byte-based iteration
qcow2: Switch store_bitmap_data() to byte-based iteration
dirty-bitmap: Switch bdrv_set_dirty() to bytes
dirty-bitmap: Convert internal hbitmap size/granularity
include/block/block_int.h | 2 +- include/block/dirty-bitmap.h | 43 ++++++-------- include/qemu/hbitmap.h | 8 +-- block/io.c | 6 +- block.c | 18 ++++-- block/backup.c | 7 +-- block/dirty-bitmap.c | 134 ++++++++++++++----------------------------- block/mirror.c | 79 +++++++++++-------------- block/qcow2-bitmap.c | 62 +++++++++++--------- block/qcow2.c | 22 ++++--- migration/block.c | 12 ++-- tests/test-hbitmap.c | 10 ++-- util/hbitmap.c | 8 +-- tests/qemu-iotests/165 | 2 +- 14 files changed, 174 insertions(+), 239 deletions(-)
Signature · 1 line
2.13.5