Skip to content

KEYS: fixes for new keyctl_dh_compute() KDF extension

Eric Biggers linux-crypto 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5KEYS: DH: forbid using digest_null as the KDF hashsecurity/keys/dh.c+11 -10 replies
2/5KEYS: DH: don't feed uninitialized "otherinfo" into KDFsecurity/keys/dh.c+1 -10 replies
3/5KEYS: DH: don't feed uninitialized result memory into KDFsecurity/keys/dh.c+10 -126 replies
4/5KEYS: DH: ensure the KDF counter is properly alignedsecurity/keys/dh.c+3 -130 replies
5/5KEYS: DH: add __user annotations to keyctl_kdf_paramsinclude/uapi/linux/keyctl.h+2 -20 replies

Reviews trailers per patch

None of the 5 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchStephan Mueller
SeriesA-b
1/5
2/5
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] KEYS: fixes for new keyctl_dh_compute() KDF extension

This patch series fixes several bugs in the KDF extension to keyctl_dh_compute() currently sitting in keys-next: a way userspace could cause an infinite loop, two ways userspace could cause the use of uninitialized memory, a misalignment, and missing __user annotations.

Eric Biggers (5):
KEYS: DH: forbid using digest_null as the KDF hash
KEYS: DH: don't feed uninitialized "otherinfo" into KDF
KEYS: DH: don't feed uninitialized result memory into KDF
KEYS: DH: ensure the KDF counter is properly aligned
KEYS: DH: add __user annotations to keyctl_kdf_params

 include/uapi/linux/keyctl.h |  4 ++--
 security/keys/dh.c          | 50 ++++++++++++++++++++++-----------------------
 2 files changed, 26 insertions(+), 28 deletions(-)
Signature · 1 line
2.12.2