Skip to content

Sparse fixes for 4.12

Leon Romanovsky linux-rdma 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4Ib/core: Mark local uverbs_std_types functions to be staticdrivers/infiniband/core/uverbs_std_types.c+24 -241 reply
2/4Ib/usnic: Explicitly include usnic headersdrivers/infiniband/hw/usnic/usnic_ib_sysfs.c drivers/infiniband/hw/usnic/usnic_ib_verbs.c+2 -00 replies
3/4IB/usnic: Simplify the code to balance loc/unlock callsdrivers/infiniband/hw/usnic/usnic_ib_verbs.c+23 -220 replies
4/4IB/nes: Fix incorrect type in assignmentdrivers/infiniband/hw/nes/nes_hw.c+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH rdma-next 0/4] Sparse fixes for 4.12

Hi Doug,

Please find below 4 patches, which fix 45 sparse warnings.

Patches #1 and #2 are trivial changes. The first adds static keyword to the functions declarations and second adds includes of the relevant headers.

Patch #3 refactors code to get rid of one temporal variable. That variable was needed to determine if QP is found. Once removed, it allowed to write the code with lock and unlock placed together.

Patch #4 fixes wrong type casting. The opcode is in CPU format and wqe_word is in le32 format.

This series is based on k.o/for-4.12-rdma-netdevice branch.

Thanks

Leon Romanovsky (4):
Ib/core: Mark local uverbs_std_types functions to be static Ib/usnic: Explicitly include usnic headers IB/usnic: Simplify the code to balance loc/unlock calls IB/nes: Fix incorrect type in assignment

 drivers/infiniband/core/uverbs_std_types.c   | 48 ++++++++++++++--------------
 drivers/infiniband/hw/nes/nes_hw.c           |  2 +-
 drivers/infiniband/hw/usnic/usnic_ib_sysfs.c |  1 +
 drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 46 +++++++++++++-------------
 4 files changed, 50 insertions(+), 47 deletions(-)

--
2.12.2

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html