Skip to content

staging: speakup: migrate synths to use TTY-based comms

Okash Khawaja lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 6 repliesIn review
  2. v16 patches 4 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6tty: export tty_open_by_driverdrivers/tty/tty_io.c include/linux/tty.h+9 -32 replies
2/6staging: speakup: add tty-based comms functionsdrivers/staging/speakup/Makefile drivers/staging/speakup/spk_priv.h drivers/staging/speakup/spk_ttyio.c +2 more+151 -00 replies
3/6staging: speakup: migrate acntsa, bns, dummy and txprt to ttyiodrivers/staging/speakup/speakup_acntsa.c drivers/staging/speakup/speakup_dummy.c drivers/staging/speakup/speakup_txprt.c+12 -120 replies
4/6staging: speakup: add send_xchar, tiocmset and input functionality for ttydrivers/staging/speakup/serialio.h drivers/staging/speakup/spk_priv.h drivers/staging/speakup/spk_ttyio.c+111 -10 replies
5/6staging: speakup: migrate apollo, ltlk, audptr, decext, dectlk and spkoutdrivers/staging/speakup/speakup_apollo.c drivers/staging/speakup/speakup_audptr.c drivers/staging/speakup/speakup_decext.c +3 more+26 -300 replies
6/6staging: speakup: flush tty buffers and ensure hardware flow controldrivers/staging/speakup/serialio.c drivers/staging/speakup/speakup_audptr.c drivers/staging/speakup/speakup_decext.c +5 more+42 -04 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchSamuel Thibault
1/6R-b
2/6R-b
3/6R-b
4/6R-b
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [patch v2 0/6] staging: speakup: migrate synths to use TTY-based comms

This patchset migrates all external synths from using raw serial i/o to using tty-based comms. The synths not migrated are internal ones - plugged directly into motherboard, communicating over ISA etc. It's important to note that these patches access TTY from inside kernel.

Here is the summary of the patches in this set.

Patch 1: Exports tty_open_by_driver in order to allow the speakup to access it.
Patch 2: Adds spk_ttyio.c, a container of TTY-based comms. Patch 3: Migrates some synths which use relatively simple comms - output only.
Patch 4: Adds more TTY-based functionality that wasn't already added in patch 2.
Patch 5: Migrates remaining external synths based.
Patch 6: Contains these fixes: flushing TTY buffers and ensuring hardware flow control.

Thanks,
Okash

Read the cover letter in its thread