Skip to content

led: ledtrig-transient: add support for hrtimer

David Lin linux-input linux-leds lkml 2 versions – Applied

Status from this message: Applied to the for-4.15 branch of linux-leds.git.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 38 repliesApplied
  2. v13 patches 5 repliesSuperseded

Changes in v2 from the cover letter

- Convert all the bit shifting flag in leds.h to use the BIT macro.
- Removed inline modifiers for the timer helper function.

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/3leds: Replace flags bit shift with BIT() macrosinclude/linux/leds.h+9 -91 reply
2/3leds: Add the LED_BRIGHTNESS_FAST flagDocumentation/leds/leds-class.txt include/linux/leds.h+6 -00 replies
3/3led: ledtrig-transient: add support for hrtimerdrivers/leds/trigger/ledtrig-transient.c+54 -50 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/3] led: ledtrig-transient: add support for hrtimer

Hi,

These patch series add the LED_BRIGHTNESS_FAST flag support for ledtrig-transient to use hrtimer so that platforms with high-resolution timer support can have better accuracy in the trigger duration timing. The need for this support is driven by the fact that Android has removed the timed_ouput [1] and is now using led-trigger for handling vibrator control which requires the timer to be accurate up to a millisecond. However, this flag support would also allow hrtimer to co-exist with the ktimer without causing warning to the existing drivers [2].

David

[1] https://patchwork.kernel.org/patch/8664831/
[2] https://lkml.org/lkml/2015/4/28/260

Changes from v1 to v2:
- Convert all the bit shifting flag in leds.h to use the BIT macro.
- Removed inline modifiers for the timer helper function.

David Lin (3):
leds: Replace flags bit shift with BIT() macros
leds: Add the LED_BRIGHTNESS_FAST flag
led: ledtrig-transient: add support for hrtimer

 Documentation/leds/leds-class.txt        |  5 +++
 drivers/leds/trigger/ledtrig-transient.c | 59 +++++++++++++++++++++++++++++---
 include/linux/leds.h                     | 19 +++++-----
 3 files changed, 69 insertions(+), 14 deletions(-)
Signature · 1 line
2.14.1.581.gf28d330327-goog

Read the cover letter in its thread