Get series with b4
b4 am [email protected]Versions newest first
- v2 Latest21 patches 17 repliesIn review
Changes in v2 from the cover letter
- fopen_or_warn() and warn_on_fopen_errors() are introduced. The latter's name is probably not great...
- A new patch (first one) to convert a bunch to using xfopen()
- Fix test failure on Windows, found by Johannes Sixt
- Fix the memory leak in log.c, found by Jeff
Patches in v2 No applies recorded yet
Reviews trailers per patch
None of the 21 patches has a Reviewed-by or Acked-by.
| Patch | Jeff King |
|---|---|
| 1/21 | |
| 2/21 | |
| 3/21 | |
| 4/21 | |
| 5/21 | |
| 6/21 | |
| 7/21 | |
| 8/21 | |
| 9/21 | |
| 10/21 | |
| 11/21 | Noticed-by |
| 12/21 | |
| 13/21 | |
| 14/21 | |
| 15/21 | |
| 16/21 | |
| 17/21 | |
| 18/21 | |
| 19/21 | |
| 20/21 | |
| 21/21 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 00/21]
Changes since v1:
- fopen_or_warn() and warn_on_fopen_errors() are introduced. The latter's name is probably not great...
- A new patch (first one) to convert a bunch to using xfopen()
- Fix test failure on Windows, found by Johannes Sixt
- Fix the memory leak in log.c, found by Jeff
There are still a couple of fopen() remained, but I'm getting slow again so let's get these in first and worry about the rest when somebody has time.
Nguyễn Thái Ngọc Duy (21):
Use xfopen() in more places
clone: use xfopen() instead of fopen()
config.mak.uname: set FREAD_READS_DIRECTORIES for Linux and FreeBSD wrapper.c: add warn_on_fopen_errors()
wrapper.c: add fopen_or_warn()
attr.c: use fopen_or_warn()
ident.c: use fopen_or_warn()
bisect: report on fopen() error
blame: report error on open if graft_file is a directory
log: report errno on failure to fopen() a file
log: fix memory leak in open_next_file()
commit.c: report error on failure to fopen() the graft file remote.c: report error on failure to fopen()
rerere.c: report error on failure to fopen()
rerere.c: report correct errno
sequencer.c: report error on failure to fopen()
server-info: report error on failure to fopen() wt-status.c: report error on failure to fopen() xdiff-interface.c: report errno on failure to stat() or fopen() config.c: handle error on failing to fopen()
t1308: add a test case on open a config directory
attr.c | 7 ++----- bisect.c | 7 ++----- builtin/am.c | 8 ++------ builtin/blame.c | 4 +++- builtin/clone.c | 2 +- builtin/commit.c | 5 +---- builtin/fast-export.c | 4 +--- builtin/fsck.c | 3 +-- builtin/log.c | 11 ++++++++--- builtin/merge.c | 4 +--- builtin/pull.c | 3 +-- commit.c | 4 +++- config.c | 5 ++++- config.mak.uname | 3 +++ diff.c | 8 ++------ dir.c | 3 +-- fast-import.c | 4 +--- git-compat-util.h | 3 +++ ident.c | 8 +++----- remote-testsvn.c | 8 ++------ remote.c | 4 ++-- rerere.c | 7 ++++--- sequencer.c | 8 ++++---- server-info.c | 2 +- t/t1308-config-set.sh | 13 ++++++++++++- t/t5512-ls-remote.sh | 13 ++++++++++--- wrapper.c | 21 +++++++++++++++++++++ wt-status.c | 3 ++- xdiff-interface.c | 4 ++-- 29 files changed, 103 insertions(+), 76 deletions(-)
Signature · 1 line
2.11.0.157.gd943d85