RFC Add blame to libgit
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 RFC Latest22 patches 6 repliesIn review
- v1 RFC10 patches 12 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/22 | blame: remove unneeded dependency on blob.hbuiltin/ | +0 | 0 replies | |
| 2/22 | blame: move textconv_object with related functionsbuiltin.h builtin/ builtin/ +2 more | +31 | 0 replies | |
| 3/22 | blame: remove unused parametersbuiltin/ | +10 | 0 replies | |
| 4/22 | blame: move origin and entry structures to headerblame.h builtin/ | +140 | 1 reply | |
| 5/22 | blame: move scoreboard structure to headerblame.h builtin/ | +57 | 0 replies | |
| 6/22 | blame: move stat counters to scoreboardblame.h builtin/ | +17 | 0 replies | |
| 7/22 | blame: move copy/move thresholds to scoreboardblame.h builtin/ | +26 | 0 replies | |
| 8/22 | blame: move contents_from to scoreboardblame.h builtin/ | +4 | 0 replies | |
| 9/22 | blame: move reverse flag to scoreboardblame.h builtin/ | +14 | 0 replies | |
| 10/22 | blame: move show_root flag to scoreboardblame.h builtin/ | +4 | 0 replies | |
| 11/22 | blame: move xdl_opts flags to scoreboardblame.h builtin/ | +5 | 0 replies | |
| 12/22 | blame: move no_whole_file_rename flag to scoreboardblame.h builtin/ | +3 | 0 replies | |
| 13/22 | blame: make sanity_check use a callback in scoreboardblame.h builtin/ | +19 | 0 replies | |
| 14/22 | blame: move progess updates to a scoreboard callbackblame.h builtin/ | +17 | 0 replies | |
| 15/22 | blame: wrap blame_sort and compare_blame_finalbuiltin/ | +9 | 0 replies | |
| 16/22 | blame: rework methods that determine 'final' commitbuiltin/ | +23 | 0 replies | |
| 17/22 | blame: move origin-related methods to libgitMakefile blame.c blame.h +1 more | +102 | 0 replies | |
| 18/22 | blame: move fake-commit-related methods to libgitblame.c blame.h builtin/ | +205 | 0 replies | |
| 19/22 | blame: move scoreboard-related methods to libgitblame.c blame.h builtin/ | +1330 | 0 replies | |
| 20/22 | blame: create scoreboard init function in libgitblame.c blame.h builtin/ | +10 | 0 replies | |
| 21/22 | blame: create scoreboard setup function in libgitblame.c blame.h builtin/ | +271 | 0 replies | |
| 22/22 | blame: create entry prepend function in libgitblame.c blame.h builtin/ | +19 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [RFC PATCH v2 00/22] Add blame to libgit
Rather than duplicate large portions of builtin/blame.c in cgit, it would be better to shift its core functionality into libgit.a. The functionality left in builtin/blame.c mostly relates to terminal presentation.
Since initial patchset:
Made commit titles consistent
Broke some commits into more atomic pieces
Fleshed out commit message bodies
Made public structure and method names more clearly blame-related
Jeff Smith (22):
blame: remove unneeded dependency on blob.h
blame: move textconv_object with related functions
blame: remove unused parameters
blame: move origin and entry structures to header
blame: move scoreboard structure to header
blame: move stat counters to scoreboard
blame: move copy/move thresholds to scoreboard
blame: move contents_from to scoreboard
blame: move reverse flag to scoreboard
blame: move show_root flag to scoreboard
blame: move xdl_opts flags to scoreboard
blame: move no_whole_file_rename flag to scoreboard
blame: make sanity_check use a callback in scoreboard
blame: move progess updates to a scoreboard callback
blame: wrap blame_sort and compare_blame_final
blame: rework methods that determine 'final' commit
blame: move origin-related methods to libgit
blame: move fake-commit-related methods to libgit
blame: move scoreboard-related methods to libgit
blame: create scoreboard init function in libgit
blame: create scoreboard setup function in libgit
blame: create entry prepend function in libgit
Makefile | 1 + blame.c | 1863 +++++++++++++++++++++++++++++++++++++++++++++ blame.h | 175 +++++ builtin.h | 2 - builtin/blame.c | 2130 ++-------------------------------------------------- builtin/cat-file.c | 1 + diff.c | 23 + diff.h | 7 + 8 files changed, 2143 insertions(+), 2059 deletions(-) create mode 100644 blame.c create mode 100644 blame.h
Signature · 1 line
2.9.3