Skip to content

RFC Add blame to libgit

Jeff Smith git 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 RFC Latest22 patches 6 repliesIn review
  2. v1 RFC10 patches 12 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/22blame: remove unneeded dependency on blob.hbuiltin/blame.c+0 -10 replies
2/22blame: move textconv_object with related functionsbuiltin.h builtin/blame.c builtin/cat-file.c +2 more+31 -300 replies
3/22blame: remove unused parametersbuiltin/blame.c+10 -150 replies
4/22blame: move origin and entry structures to headerblame.h builtin/blame.c+140 -1311 reply
5/22blame: move scoreboard structure to headerblame.h builtin/blame.c+57 -550 replies
6/22blame: move stat counters to scoreboardblame.h builtin/blame.c+17 -170 replies
7/22blame: move copy/move thresholds to scoreboardblame.h builtin/blame.c+26 -200 replies
8/22blame: move contents_from to scoreboardblame.h builtin/blame.c+4 -00 replies
9/22blame: move reverse flag to scoreboardblame.h builtin/blame.c+14 -90 replies
10/22blame: move show_root flag to scoreboardblame.h builtin/blame.c+4 -10 replies
11/22blame: move xdl_opts flags to scoreboardblame.h builtin/blame.c+5 -30 replies
12/22blame: move no_whole_file_rename flag to scoreboardblame.h builtin/blame.c+3 -10 replies
13/22blame: make sanity_check use a callback in scoreboardblame.h builtin/blame.c+19 -80 replies
14/22blame: move progess updates to a scoreboard callbackblame.h builtin/blame.c+17 -100 replies
15/22blame: wrap blame_sort and compare_blame_finalbuiltin/blame.c+9 -80 replies
16/22blame: rework methods that determine 'final' commitbuiltin/blame.c+23 -260 replies
17/22blame: move origin-related methods to libgitMakefile blame.c blame.h +1 more+102 -960 replies
18/22blame: move fake-commit-related methods to libgitblame.c blame.h builtin/blame.c+205 -1990 replies
19/22blame: move scoreboard-related methods to libgitblame.c blame.h builtin/blame.c+1330 -13240 replies
20/22blame: create scoreboard init function in libgitblame.c blame.h builtin/blame.c+10 -30 replies
21/22blame: create scoreboard setup function in libgitblame.c blame.h builtin/blame.c+271 -2650 replies
22/22blame: create entry prepend function in libgitblame.c blame.h builtin/blame.c+19 -100 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [RFC PATCH v2 00/22] Add blame to libgit

Rather than duplicate large portions of builtin/blame.c in cgit, it would be better to shift its core functionality into libgit.a. The functionality left in builtin/blame.c mostly relates to terminal presentation.

Since initial patchset:
Made commit titles consistent
Broke some commits into more atomic pieces
Fleshed out commit message bodies
Made public structure and method names more clearly blame-related

Jeff Smith (22):
blame: remove unneeded dependency on blob.h
blame: move textconv_object with related functions
blame: remove unused parameters
blame: move origin and entry structures to header
blame: move scoreboard structure to header
blame: move stat counters to scoreboard
blame: move copy/move thresholds to scoreboard
blame: move contents_from to scoreboard
blame: move reverse flag to scoreboard
blame: move show_root flag to scoreboard
blame: move xdl_opts flags to scoreboard
blame: move no_whole_file_rename flag to scoreboard
blame: make sanity_check use a callback in scoreboard
blame: move progess updates to a scoreboard callback
blame: wrap blame_sort and compare_blame_final
blame: rework methods that determine 'final' commit
blame: move origin-related methods to libgit
blame: move fake-commit-related methods to libgit
blame: move scoreboard-related methods to libgit
blame: create scoreboard init function in libgit
blame: create scoreboard setup function in libgit
blame: create entry prepend function in libgit

 Makefile           |    1 +
 blame.c            | 1863 +++++++++++++++++++++++++++++++++++++++++++++
 blame.h            |  175 +++++
 builtin.h          |    2 -
 builtin/blame.c    | 2130 ++--------------------------------------------------
 builtin/cat-file.c |    1 +
 diff.c             |   23 +
 diff.h             |    7 +
 8 files changed, 2143 insertions(+), 2059 deletions(-)
 create mode 100644 blame.c
 create mode 100644 blame.h
Signature · 1 line
2.9.3